Skip to content

[FLINK-36659][docs] Update Kafka connector docs for 4.0.0 #26501

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
+3 −3
Open

[FLINK-36659][docs] Update Kafka connector docs for 4.0.0 #26501

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions docs/data/sql_connectors.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -156,15 +156,15 @@ kafka:
versions:
- version: universal
maven: flink-connector-kafka
sql_url: https://repo.maven.apache.org/maven2/org/apache/flink/flink-sql-connector-kafka/$version/flink-sql-connector-kafka-$version.jar
sql_url: https://repo.maven.apache.org/maven2/org/apache/flink/flink-sql-connector-kafka/4.0.0-2.0/flink-sql-connector-kafka-4.0.0-2.0.jar
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am wondering why need to hard code the version.
I assume prior to this change the version was coming through as 3.4.0-1.20 or was this never working?
If we have to hard code - it would make sense to introduce a new variable , maybe constructed from $version


upsert-kafka:
name: Upsert Kafka
category: connector
versions:
- version: universal
maven: flink-connector-kafka
sql_url: https://repo.maven.apache.org/maven2/org/apache/flink/flink-sql-connector-kafka/$version/flink-sql-connector-kafka-$version.jar
sql_url: https://repo.maven.apache.org/maven2/org/apache/flink/flink-sql-connector-kafka/4.0.0-2.0/flink-sql-connector-kafka-4.0.0-2.0.jar

kinesis:
name: Amazon Kinesis Data Streams
Expand Down
2 changes: 1 addition & 1 deletion docs/setup_docs.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,7 +60,7 @@ if [ "$SKIP_INTEGRATE_CONNECTOR_DOCS" = false ]; then
integrate_connector_docs gcp-pubsub v3.0
integrate_connector_docs mongodb v2.0
integrate_connector_docs opensearch v1.2
integrate_connector_docs kafka v3.3
integrate_connector_docs kafka v4.0
integrate_connector_docs hbase v4.0
integrate_connector_docs prometheus v1.0
integrate_connector_docs hive v3.0
Expand Down