Use isEmpty() instead of length() > 0 in WordCount Tokenizer #26749
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Seems acceptable.
But the PR title should be formal by following this guide:
https://flink.apache.org/how-to-contribute/contribute-code/
github-actions
bot
added
community-reviewed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The change enhances code clarity by using the semantically appropriate method provided by the String API. Although functionally equivalent, ‘isEmpty()’ more clearly communicates the intent of checking for an empty string, aligning with common Java coding practices. This improves maintainability and consistency across the codebase.