Skip to content

[FLINK-38022][table] Throw exception in main thread in tests when any exception is thrown in async thread during looking up #26752

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 7, 2025
Merged

[FLINK-38022][table] Throw exception in main thread in tests when any exception is thrown in async thread during looking up #26752

merged 2 commits into from
Jul 7, 2025

Conversation

xuyangzhong
Copy link
Contributor

@xuyangzhong xuyangzhong commented Jul 4, 2025 •
edited
Loading

What is the purpose of the change

This pr aims to do two things:

  1. tell us what happens in StreamingDeltaJoinOperatorTest instead of hanging the CI
    image
    https://github.com/apache/flink/actions/runs/15920474470/job/44906494863

  2. this pr is also trying to fix the potential bugs causing the hang for ConcurrentModificationException while copying list in tests

Brief change log

  • Collect exceptions when doing delta join
  • Avoid ConcurrentModificationException when copying list

Verifying this change

New and existent tests can cover this pr.

Does this pull request potentially affect one of the following parts:

  • Dependencies (does it add or upgrade a dependency): no
  • The public API, i.e., is any changed class annotated with @Public(Evolving): no
  • The serializers: no
  • The runtime per-record code paths (performance sensitive): no
  • Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: no
  • The S3 file system connector: no

Documentation

  • Does this pull request introduce a new feature? no
  • If yes, how is the feature documented?

@xuyangzhong
[FLINK-38022][table] Throw exception in main thread in tests when any…
b13c51e 
… exception is thrown in async thread during looking up

Furthermore, this pr is also trying to fix the potential bugs for ConcurrentModificationException while copying list in tests.
@xuyangzhong
Copy link
Contributor Author

@Au-Miner Can you please take a look at this pr?

@flinkbot
Copy link
Collaborator

flinkbot commented Jul 4, 2025 •
edited
Loading

CI report:

Bot commands The @flinkbot bot supports the following commands:
  • @flinkbot run azure re-run the last Azure build

@Au-Miner
Copy link
Contributor

Au-Miner commented Jul 4, 2025

Thanks for improving the testing code logic!

@github-actions github-actions bot added community-reviewed PR has been reviewed by the community. and removed community-reviewed PR has been reviewed by the community. labels Jul 4, 2025
@github-actions github-actions bot added community-reviewed PR has been reviewed by the community. and removed community-reviewed PR has been reviewed by the community. labels Jul 7, 2025
@xuyangzhong xuyangzhong merged commit d4c76dc into apache:master Jul 7, 2025
xuyangzhong added a commit to xuyangzhong/flink that referenced this pull request Jul 7, 2025
@xuyangzhong
[FLINK-38022][table] Throw exception in main thread in tests when any…
2b1b9d6 
… exception is thrown in async thread during looking up (apache#26752)

* [FLINK-38022][table] Throw exception in main thread in tests when any exception is thrown in async thread during looking up

* Furthermore, this pr is also trying to fix the potential bugs for ConcurrentModificationException while copying list in tests.

(cherry picked from commit d4c76dc)
@xuyangzhong xuyangzhong mentioned this pull request Jul 7, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davidradl davidradl davidradl left review comments

@Au-Miner Au-Miner Au-Miner approved these changes

Assignees
No one assigned
Labels
community-reviewed PR has been reviewed by the community.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@xuyangzhong @flinkbot @Au-Miner @davidradl