-
Notifications
You must be signed in to change notification settings - Fork 13.7k
[FLINK-38253] Allow usage of vertx/jdk/jetty/okhttp clients in fabric8 in flink-kubernetes #26908
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Frawless
wants to merge
1
commit into
apache:master
Choose a base branch
from
Frawless:flink-kube-option-http-client
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+362
−1
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,98 @@ | ||
| # Licensed to the Apache Software Foundation (ASF) under one or more | ||
| # contributor license agreements. See the NOTICE file distributed with | ||
| # this work for additional information regarding copyright ownership. | ||
| # The ASF licenses this file to You under the Apache License, Version 2.0 | ||
| # (the "License"); you may not use this file except in compliance with | ||
| # the License. You may obtain a copy of the License at | ||
| # | ||
| # http://www.apache.org/licenses/LICENSE-2.0 | ||
| # | ||
| # Unless required by applicable law or agreed to in writing, software | ||
| # distributed under the License is distributed on an "AS IS" BASIS, | ||
| # WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| # See the License for the specific language governing permissions and | ||
| # limitations under the License. | ||
|
|
||
| # Workflow template for triggering the Flink's test suite. | ||
|
|
||
| name: "Apache Flink Test Workflow Template - for module flink-kubernetes" | ||
|
|
||
| on: | ||
| workflow_call: | ||
| inputs: | ||
| http-client: | ||
| description: "Type of fabric8 HTTP client implementation (okhttp, vertx, jetty, jdk)" | ||
| default: okhttp | ||
| type: string | ||
| jdk_version: | ||
| description: "Java version" | ||
| default: "17" | ||
| type: string | ||
| cache-name: | ||
| description: "Suffix for artifacts name in cache" | ||
| default: "" | ||
| type: string | ||
| environment: | ||
| description: "Defines environment variables for downstream scripts." | ||
| required: true | ||
| type: string | ||
|
|
||
| permissions: read-all | ||
|
|
||
| env: | ||
| # The following environment variables need to be overwritten here because the e2e tests do not | ||
| # run in containers. | ||
| MAVEN_REPO_FOLDER: ${{ github.workspace }}/.m2/repository | ||
| MAVEN_ARGS: -Dmaven.repo.local=${{ github.workspace }}/.m2/repository | ||
| FLINK_ARTIFACT_DIR: ${{ github.workspace }} | ||
| DOCKER_IMAGES_CACHE_FOLDER: ${{ github.workspace }}/.docker-cache | ||
|
|
||
| jobs: | ||
| build-and-test: | ||
| runs-on: ubuntu-22.04 | ||
| steps: | ||
| - name: "Flink Checkout" | ||
| uses: actions/checkout@v4 | ||
| with: | ||
| persist-credentials: false | ||
|
|
||
| - name: "Initialize job" | ||
| uses: "./.github/actions/job_init" | ||
| with: | ||
| jdk_version: ${{ inputs.jdk_version }} | ||
| maven_repo_folder: ${{ env.MAVEN_REPO_FOLDER }} | ||
|
|
||
| - name: "Download build artifacts from compile job" | ||
| uses: actions/download-artifact@v4 | ||
| with: | ||
| name: build-artifacts-${{ inputs.cache-name }} | ||
| path: ${{ env.FLINK_ARTIFACT_DIR }} | ||
|
|
||
| - name: "Unpack build artifact" | ||
| run: ./tools/azure-pipelines/unpack_build_artifact.sh | ||
|
|
||
| - name: "Build Flink" | ||
| uses: "./.github/actions/run_mvn" | ||
| timeout-minutes: 20 | ||
| with: | ||
| maven-parameters: "install -DskipTests -Dfast $PROFILE -Pskip-webui-build -Phttpclient-${{ inputs.http-client }}" | ||
| env: "${{ inputs.environment }}" | ||
|
|
||
| - name: "Build flink-kubernetes with ${{ inputs.http-client }} with unit tests" | ||
| timeout-minutes: 20 | ||
| run: | | ||
| ./mvnw install -pl flink-kubernetes -Phttpclient-${{ inputs.http-client }} | ||
|
|
||
| - name: "Run ITs" | ||
| timeout-minutes: 20 | ||
| run: | | ||
| FLINK_DIR=`pwd`/build-target ./flink-end-to-end-tests/run-single-test.sh ./flink-end-to-end-tests/test-scripts/test_kubernetes_itcases.sh | ||
| env: | ||
| MAVEN_ARGS: "-Phttpclient-${{ inputs.http-client }}" | ||
|
|
||
| - name: "Run e2e smoke" | ||
| timeout-minutes: 20 | ||
| run: | | ||
| FLINK_DIR=`pwd`/build-target ./flink-end-to-end-tests/run-single-test.sh ./flink-end-to-end-tests/test-scripts/test_kubernetes_application.sh | ||
| env: | ||
| MAVEN_ARGS: "-Phttpclient-${{ inputs.http-client }}" |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am curious how long do all these new testing permutations add to the ci times?
Also in the spirit of FLINK-33901, should we implement these new CI tests in github actions rather than the Azure CI?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In my fork it was 4 parallel jobs, around 25 minutes per each and it finished like 1h before current jobs for e2e tests that were running in parallel with these new ones. I basically followed the same approach as was implemented in operator repo as part of apache/flink-kubernetes-operator#881
Regarding Azure vs GHA, my understanding was that Flink community is aiming to move from Azure to GHA, that's the reason why I implemented it there. If we agree that Azure is a preferable way, I am happy to extend Azure pipelines. I understand this might need longer discussion so implementation in this PR can be used more like as a PoC.