[VL][CI] Add a format checker for scala code to enable early failure reporting#10747
[VL][CI] Add a format checker for scala code to enable early failure reporting#10747philo-he merged 2 commits intoapache:mainfrom
Conversation
philo-he
force-pushed
the
precheck
branch
3 times, most recently
from
1d89296 to
d15fd82
Compare
|
@zhouyuan, could you take a look? This is part of preliminary checks. |
philo-he
force-pushed
the
precheck
branch
2 times, most recently
from
0932d26 to
3569f34
Compare
| # limitations under the License. | ||
|
|
||
| name: Velox backend Github Runner (Enhanced Features) | ||
| name: Velox Backend (Enhanced) |
There was a problem hiding this comment.
nit, once may not figure out the meaning of Enhanced at first glance.
There was a problem hiding this comment.
@zhztheplayer, thanks for the comment. I feel this simple name is descriptive enough, especially since it's intended for developers only. Not a strong preference. I can revert to the full name if you think it's more appropriate. :)
There was a problem hiding this comment.
No, just keep it if you have strong reason. Never tended to be nitpicking :)
| PROFILES="-Pbackends-velox -Pceleborn,uniffle -Piceberg,delta,hudi,paimon \ | ||
| -Pspark-3.2,spark-3.3,spark-3.4,spark-3.5,spark-4.0 -Pspark-ut" |
There was a problem hiding this comment.
If this is not for a CI task that is only for VL backend, let's add CH's code as well.
There was a problem hiding this comment.
Thanks for the comment. I note all scripts under dev/ are related to velox backend. Perhaps it’s better to continue excluding the CH backend in this script.
|
@zhztheplayer, could you take a look again? The CI failure has been fixed by this patch, but that job always uses upstream gluten for verification due to some known issues of checkout plugin on Centos-7. |
2 participants
What changes are proposed in this pull request?
Previously, code format violations were reported by the CI during scala code build, after completing the time-consuming native code build. We should perform these preliminary checks earlier to quickly surface issues, potentially saving CI resources.
How was this patch tested?