Adds validation tests for several previously untested timestamp funct…#11890
Open
Mariamalmesfer wants to merge 1 commit intoapache:mainfrom
Open
Adds validation tests for several previously untested timestamp funct…#11890Mariamalmesfer wants to merge 1 commit intoapache:mainfrom
Mariamalmesfer wants to merge 1 commit intoapache:mainfrom
Conversation
Mariamalmesfer
force-pushed
the
validate-timestamp-functions
branch
10 times, most recently
from
dd0cf60 to
32fd842
Compare
Member
|
@Mariamalmesfer Thanks for the improvement, is this patch ready for review? |
Mariamalmesfer
force-pushed
the
validate-timestamp-functions
branch
from
30257c6 to
9565c82
Compare
Mariamalmesfer
force-pushed
the
validate-timestamp-functions
branch
from
9565c82 to
5797c15
Compare
Contributor
Author
Yes, it’s ready for review. I was planning to include cast coverage here, but I’ll add it in a separate PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add tests for some missing timestamp functions in the Velox backend.
New tests include:
Minute
Second
SecondsToTimestamp
ToUnixTimestamp
FromUnixTime
LastDay
NextDay