Skip to content

[MINOR] Refactor: move ClickHouse-specific extension tests to backend module#11926

Merged
philo-he merged 3 commits intoapache:mainfrom
philo-he:refactor-ut
Apr 15, 2026
Merged

[MINOR] Refactor: move ClickHouse-specific extension tests to backend module#11926
philo-he merged 3 commits intoapache:mainfrom
philo-he:refactor-ut

Conversation

@philo-he
Copy link
Copy Markdown
Member

@philo-he philo-he commented Apr 13, 2026

What changes are proposed in this pull request?

The functionality covered by GlutenCustomerExtensionSuite is currently supported only by the ClickHouse backend. This PR refactors the test organization to improve maintainability and reduce overhead for the Velox backend.

  • Moved GlutenCustomerExtensionSuite and its associated rules from the common (gluten-ut) module to the backends-clickhouse module.

  • Removed TestFileSourceScanExecTransformer from the test enablement list in VeloxTestSettings. This was incorrectly flagged as a test suite since it is actually a helper class for testing.

  • By isolating these tests, we avoid unnecessary maintenance efforts and potential build interference for other backends that do not support these custom extensions.

How was this patch tested?

CI.

Was this patch authored or co-authored using generative AI tooling?

No.

@github-actions github-actions bot added CORE works for Gluten Core CLICKHOUSE labels Apr 13, 2026
@github-actions
Copy link
Copy Markdown

Run Gluten Clickhouse CI on x86

@philo-he philo-he marked this pull request as draft April 13, 2026 04:55
@github-actions
Copy link
Copy Markdown

Run Gluten Clickhouse CI on x86

@github-actions
Copy link
Copy Markdown

Run Gluten Clickhouse CI on x86

@philo-he philo-he changed the title [MINOR] Refactor: Move CustomerColumnarPreRules to ClickHouse module [MINOR] Refactor: move ClickHouse-specific extension tests to backend module Apr 14, 2026
@philo-he philo-he marked this pull request as ready for review April 14, 2026 06:18
@philo-he
Copy link
Copy Markdown
Member Author

@zhouyuan, could you take a look? Thanks.

@zhouyuan zhouyuan requested a review from zzcclp April 14, 2026 08:51
Copy link
Copy Markdown
Contributor

@zzcclp zzcclp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@philo-he philo-he merged commit 0d0890f into apache:main Apr 15, 2026
66 checks passed
@philo-he philo-he deleted the refactor-ut branch April 15, 2026 06:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLICKHOUSE CORE works for Gluten Core

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants