Skip to content

[VL] Optimize bhj hash table built performance#11927

Merged
JkSelf merged 2 commits intoapache:mainfrom
JkSelf:bhj-hashtable-optimization
Apr 14, 2026
Merged

[VL] Optimize bhj hash table built performance#11927
JkSelf merged 2 commits intoapache:mainfrom
JkSelf:bhj-hashtable-optimization

Conversation

@JkSelf
Copy link
Copy Markdown
Contributor

@JkSelf JkSelf commented Apr 13, 2026

What changes are proposed in this pull request?

Move facebookincubator/velox@e7810c9 and https://github.com/facebookincubator/velox/blob/948e7be0619f8d123ae9d8fbd8a4f7b928492aec/velox/exec/HashBuild.h#L222-L228 two optimizations into HashTableBuilder.

How was this patch tested?

Existing tests

Was this patch authored or co-authored using generative AI tooling?

no

@github-actions github-actions bot added CORE works for Gluten Core VELOX labels Apr 13, 2026
@github-actions
Copy link
Copy Markdown

Run Gluten Clickhouse CI on x86

@JkSelf JkSelf force-pushed the bhj-hashtable-optimization branch from aac2cfb to c3e1cab Compare April 13, 2026 10:15
@github-actions github-actions bot added the DOCS label Apr 13, 2026
@github-actions
Copy link
Copy Markdown

Run Gluten Clickhouse CI on x86

1 similar comment
@github-actions
Copy link
Copy Markdown

Run Gluten Clickhouse CI on x86

@JkSelf JkSelf force-pushed the bhj-hashtable-optimization branch from b590144 to 6cc7091 Compare April 13, 2026 13:37
@github-actions
Copy link
Copy Markdown

Run Gluten Clickhouse CI on x86

@JkSelf JkSelf changed the title [VL][test]Bhj hashtable optimization [VL] Optimize bhj hash table built performance Apr 13, 2026
Comment thread cpp/velox/jni/VeloxJniWrapper.cc Outdated
Comment thread cpp/velox/jni/VeloxJniWrapper.cc Outdated
Comment thread cpp/velox/jni/VeloxJniWrapper.cc Outdated
Comment thread cpp/velox/jni/VeloxJniWrapper.cc Outdated
@github-actions
Copy link
Copy Markdown

Run Gluten Clickhouse CI on x86

@JkSelf
Copy link
Copy Markdown
Contributor Author

JkSelf commented Apr 14, 2026

@jinchengchenghh Resolved all your comments. Could you help to review again? Thanks.

@JkSelf JkSelf force-pushed the bhj-hashtable-optimization branch from 129cffd to c2e4216 Compare April 14, 2026 09:31
@github-actions
Copy link
Copy Markdown

Run Gluten Clickhouse CI on x86

@JkSelf JkSelf force-pushed the bhj-hashtable-optimization branch from c2e4216 to da67262 Compare April 14, 2026 12:57
@github-actions
Copy link
Copy Markdown

Run Gluten Clickhouse CI on x86

@github-actions
Copy link
Copy Markdown

Run Gluten Clickhouse CI on x86

@JkSelf JkSelf merged commit 02bf50b into apache:main Apr 14, 2026
61 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CORE works for Gluten Core DOCS VELOX

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants