GROOVY-9526, GROOVY-11719: pop field state on exception

[eric-milles]

As described on the mailing list, ResolveVisitor#genericParameterNames can get stuck with Collections.EMPTY_MAP value if field or property visitation throws exception.

See also #2271

[codecov-commenter]

Codecov Report

Attention: Patch coverage is 93.54839% with 6 lines in your changes missing coverage. Please review.

Project coverage is 68.0192%. Comparing base (f104983) to head (f54031d).

Files with missing lines	Patch %	Lines
...va/org/codehaus/groovy/control/ResolveVisitor.java	93.5484%	1 Missing and 5 partials ⚠️

Additional details and impacted files

@@                Coverage Diff                 @@
##               master      #2272        +/-   ##
==================================================
+ Coverage     68.0122%   68.0192%   +0.0070%     
  Complexity      29200      29200                
==================================================
  Files            1377       1377                
  Lines          114259     114256         -3     
  Branches        19839      19839                
==================================================
+ Hits            77710      77716         +6     
+ Misses          30211      30206         -5     
+ Partials         6338       6334         -4     

Files with missing lines	Coverage Δ
...va/org/codehaus/groovy/control/ResolveVisitor.java	90.1266% <93.5484%> (-0.0373%)	⬇️

... and 4 files with indirect coverage changes

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.