Skip to content

HADOOP-19618. Replace AssumptionViolatedException with TestAbortedException. #7800

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: trunk
Choose a base branch
from

Conversation

slfan1989
Copy link
Contributor

Description of PR

JIRA: HADOOP-19618. Replace AssumptionViolatedException with TestAbortedException.

In JUnit 4, org.junit.internal.AssumptionViolatedException is used to indicate assumption failure and skip the test. However, AssumptionViolatedException is an implementation in JUnit 4, and in JUnit 5, we can use TestAbortedException to replace AssumptionViolatedException.

TestAbortedException is used to indicate that a test has been aborted, and it can be used to replace AssumptionViolatedException. However, it is not directly related to assumption failure and is more commonly used in situations where the test needs to be aborted during execution.

How was this patch tested?

Junit Test.

For code changes:

  • Does the title or this PR starts with the corresponding JIRA issue id (e.g. 'HADOOP-17799. Your PR title ...')?
  • Object storage: have the integration tests been executed and the endpoint declared according to the connector-specific documentation?
  • If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?
  • If applicable, have you updated the LICENSE, LICENSE-binary, NOTICE-binary files?

@hadoop-yetus
Copy link

🎊 +1 overall

Vote Subsystem Runtime Logfile Comment
+0 🆗 reexec 0m 50s Docker mode activated.
_ Prechecks _
+1 💚 dupname 0m 0s No case conflicting files found.
+0 🆗 codespell 0m 0s codespell was not available.
+0 🆗 detsecrets 0m 0s detect-secrets was not available.
+1 💚 @author 0m 0s The patch does not contain any @author tags.
+1 💚 test4tests 0m 0s The patch appears to include 12 new or modified test files.
_ trunk Compile Tests _
+0 🆗 mvndep 5m 48s Maven dependency ordering for branch
+1 💚 mvninstall 38m 26s trunk passed
+1 💚 compile 18m 10s trunk passed with JDK Ubuntu-11.0.27+6-post-Ubuntu-0ubuntu120.04
+1 💚 compile 15m 28s trunk passed with JDK Private Build-1.8.0_452-8u452-gaus1-0ubuntu120.04-b09
+1 💚 checkstyle 4m 41s trunk passed
+1 💚 mvnsite 7m 20s trunk passed
+1 💚 javadoc 6m 33s trunk passed with JDK Ubuntu-11.0.27+6-post-Ubuntu-0ubuntu120.04
+1 💚 javadoc 6m 15s trunk passed with JDK Private Build-1.8.0_452-8u452-gaus1-0ubuntu120.04-b09
+1 💚 spotbugs 11m 22s trunk passed
+1 💚 shadedclient 42m 23s branch has no errors when building and testing our client artifacts.
_ Patch Compile Tests _
+0 🆗 mvndep 0m 33s Maven dependency ordering for patch
+1 💚 mvninstall 4m 12s the patch passed
+1 💚 compile 17m 14s the patch passed with JDK Ubuntu-11.0.27+6-post-Ubuntu-0ubuntu120.04
+1 💚 javac 17m 14s the patch passed
+1 💚 compile 15m 24s the patch passed with JDK Private Build-1.8.0_452-8u452-gaus1-0ubuntu120.04-b09
+1 💚 javac 15m 24s the patch passed
+1 💚 blanks 0m 0s The patch has no blanks issues.
+1 💚 checkstyle 4m 44s the patch passed
+1 💚 mvnsite 7m 13s the patch passed
+1 💚 javadoc 6m 30s the patch passed with JDK Ubuntu-11.0.27+6-post-Ubuntu-0ubuntu120.04
+1 💚 javadoc 6m 16s the patch passed with JDK Private Build-1.8.0_452-8u452-gaus1-0ubuntu120.04-b09
+1 💚 spotbugs 12m 36s the patch passed
+1 💚 shadedclient 43m 18s patch has no errors when building and testing our client artifacts.
_ Other Tests _
+1 💚 unit 22m 53s hadoop-common in the patch passed.
+1 💚 unit 104m 3s hadoop-hdfs in the patch passed.
+1 💚 unit 3m 53s hadoop-aws in the patch passed.
+1 💚 unit 3m 7s hadoop-azure in the patch passed.
+1 💚 unit 0m 45s hadoop-aliyun in the patch passed.
+1 💚 unit 0m 45s hadoop-cos in the patch passed.
+1 💚 unit 0m 46s hadoop-huaweicloud in the patch passed.
+1 💚 asflicense 1m 10s The patch does not generate ASF License warnings.
419m 4s
Subsystem Report/Notes
Docker ClientAPI=1.51 ServerAPI=1.51 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-7800/1/artifact/out/Dockerfile
GITHUB PR #7800
Optional Tests dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets
uname Linux ca7de1a90d3f 5.15.0-139-generic #149-Ubuntu SMP Fri Apr 11 22:06:13 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/bin/hadoop.sh
git revision trunk / 717ce8a
Default Java Private Build-1.8.0_452-8u452-gaus1-0ubuntu120.04-b09
Multi-JDK versions /usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.27+6-post-Ubuntu-0ubuntu120.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_452-8u452-gaus1-0ubuntu120.04-b09
Test Results https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-7800/1/testReport/
Max. process+thread count 1894 (vs. ulimit of 5500)
modules C: hadoop-common-project/hadoop-common hadoop-hdfs-project/hadoop-hdfs hadoop-tools/hadoop-aws hadoop-tools/hadoop-azure hadoop-tools/hadoop-aliyun hadoop-cloud-storage-project/hadoop-cos hadoop-cloud-storage-project/hadoop-huaweicloud U: .
Console output https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-7800/1/console
versions git=2.25.1 maven=3.6.3 spotbugs=4.2.2
Powered by Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

@slfan1989 slfan1989 marked this pull request as ready for review July 13, 2025 09:12
@slfan1989 slfan1989 requested a review from cnauroth July 13, 2025 09:12
@slfan1989
Copy link
Contributor Author

@cnauroth Could you help review this PR? Thank you very much!

Copy link
Contributor

@zhtttylz zhtttylz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1,LGTM @slfan1989

@steveloughran
Copy link
Contributor

maybe we should create our own exceptions for assumption failures, aborted, timed out and use in our code; they could be subclasses of the JUnit equivalent, but give us a bit more independence in future.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants