-
Notifications
You must be signed in to change notification settings - Fork 9.1k
HADOOP-19626. Updates AAL to v1.2.1. #7807
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@steveloughran @mukund-thakur small PR to update AAL version. We've made a few improvements since 1.0.0, mainly in how memory is managed. So would be great to get 3.4.2 released with 1.2.1, instead of the current 1.0.0 version. This also brings in support for readVectored, IoStats and SSE-C, which is required by the other PR's we have up. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add the test results before merging.
a provisional +1 pending that test result. |
🎊 +1 overall
This message was automatically generated. |
LGTM! |
@steveloughran @mukund-thakur since mosts tests are currently failing in trunk currently due to the Junit 5 migration, what is our strategy for running tests and getting things merged in? Is it enough to test this on 3.4 and if all ok there merge here? |
I think we can test this in 3.4 and merge. The failing tests in trunk would be unrelated to this change for sure. |
tested on branch 3.4 in eu-west-1, all good. found one unrelated failure: https://issues.apache.org/jira/browse/HADOOP-19627, will fix |
Contributed by: Ahmar Suhail
…#7807) Contributed by: Ahmar Suhail
Contributed by: Ahmar Suhail
Description of PR
Updates to AAL v1.2.1, which brings in better memory management, as well as support for readVectored and SSE-C.
How was this patch tested?
in progress