Skip to content

HADOOP-19626. Updates AAL to v1.2.1. #7807

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 18, 2025

Conversation

ahmarsuhail
Copy link
Contributor

Description of PR

Updates to AAL v1.2.1, which brings in better memory management, as well as support for readVectored and SSE-C.

How was this patch tested?

in progress

@ahmarsuhail
Copy link
Contributor Author

@steveloughran @mukund-thakur small PR to update AAL version. We've made a few improvements since 1.0.0, mainly in how memory is managed. So would be great to get 3.4.2 released with 1.2.1, instead of the current 1.0.0 version.

This also brings in support for readVectored, IoStats and SSE-C, which is required by the other PR's we have up.

Copy link
Contributor

@mukund-thakur mukund-thakur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add the test results before merging.

@steveloughran
Copy link
Contributor

a provisional +1 pending that test result.

@hadoop-yetus
Copy link

🎊 +1 overall

Vote Subsystem Runtime Logfile Comment
+0 🆗 reexec 8m 30s Docker mode activated.
_ Prechecks _
+1 💚 dupname 0m 0s No case conflicting files found.
+0 🆗 codespell 0m 0s codespell was not available.
+0 🆗 detsecrets 0m 0s detect-secrets was not available.
+0 🆗 xmllint 0m 0s xmllint was not available.
+1 💚 @author 0m 0s The patch does not contain any @author tags.
+1 💚 test4tests 0m 0s The patch appears to include 1 new or modified test files.
_ trunk Compile Tests _
+0 🆗 mvndep 29m 1s Maven dependency ordering for branch
+1 💚 mvninstall 19m 55s trunk passed
+1 💚 compile 8m 42s trunk passed with JDK Ubuntu-11.0.27+6-post-Ubuntu-0ubuntu120.04
+1 💚 compile 7m 26s trunk passed with JDK Private Build-1.8.0_452-8u452-gaus1-0ubuntu120.04-b09
+1 💚 checkstyle 1m 59s trunk passed
+1 💚 mvnsite 1m 7s trunk passed
+1 💚 javadoc 1m 5s trunk passed with JDK Ubuntu-11.0.27+6-post-Ubuntu-0ubuntu120.04
+1 💚 javadoc 0m 59s trunk passed with JDK Private Build-1.8.0_452-8u452-gaus1-0ubuntu120.04-b09
+0 🆗 spotbugs 0m 33s branch/hadoop-project no spotbugs output file (spotbugsXml.xml)
+1 💚 shadedclient 21m 53s branch has no errors when building and testing our client artifacts.
_ Patch Compile Tests _
+0 🆗 mvndep 0m 25s Maven dependency ordering for patch
+1 💚 mvninstall 0m 30s the patch passed
+1 💚 compile 8m 10s the patch passed with JDK Ubuntu-11.0.27+6-post-Ubuntu-0ubuntu120.04
+1 💚 javac 8m 10s the patch passed
+1 💚 compile 7m 31s the patch passed with JDK Private Build-1.8.0_452-8u452-gaus1-0ubuntu120.04-b09
+1 💚 javac 7m 31s the patch passed
+1 💚 blanks 0m 0s The patch has no blanks issues.
+1 💚 checkstyle 1m 57s the patch passed
+1 💚 mvnsite 1m 5s the patch passed
+1 💚 javadoc 1m 0s the patch passed with JDK Ubuntu-11.0.27+6-post-Ubuntu-0ubuntu120.04
+1 💚 javadoc 0m 52s the patch passed with JDK Private Build-1.8.0_452-8u452-gaus1-0ubuntu120.04-b09
+0 🆗 spotbugs 0m 25s hadoop-project has no data from spotbugs
+1 💚 shadedclient 22m 16s patch has no errors when building and testing our client artifacts.
_ Other Tests _
+1 💚 unit 0m 25s hadoop-project in the patch passed.
+1 💚 unit 2m 56s hadoop-aws in the patch passed.
+1 💚 asflicense 0m 44s The patch does not generate ASF License warnings.
154m 3s
Subsystem Report/Notes
Docker ClientAPI=1.51 ServerAPI=1.51 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-7807/1/artifact/out/Dockerfile
GITHUB PR #7807
Optional Tests dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient codespell detsecrets xmllint spotbugs checkstyle
uname Linux ab80cb09cc84 5.15.0-143-generic #153-Ubuntu SMP Fri Jun 13 19:10:45 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/bin/hadoop.sh
git revision trunk / d061014
Default Java Private Build-1.8.0_452-8u452-gaus1-0ubuntu120.04-b09
Multi-JDK versions /usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.27+6-post-Ubuntu-0ubuntu120.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_452-8u452-gaus1-0ubuntu120.04-b09
Test Results https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-7807/1/testReport/
Max. process+thread count 716 (vs. ulimit of 5500)
modules C: hadoop-project hadoop-tools/hadoop-aws U: .
Console output https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-7807/1/console
versions git=2.25.1 maven=3.6.3 spotbugs=4.2.2
Powered by Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

@stubz151
Copy link

LGTM!

@ahmarsuhail
Copy link
Contributor Author

@steveloughran @mukund-thakur since mosts tests are currently failing in trunk currently due to the Junit 5 migration, what is our strategy for running tests and getting things merged in?

Is it enough to test this on 3.4 and if all ok there merge here?

@mukund-thakur
Copy link
Contributor

I think we can test this in 3.4 and merge. The failing tests in trunk would be unrelated to this change for sure.

@ahmarsuhail
Copy link
Contributor Author

tested on branch 3.4 in eu-west-1, all good. found one unrelated failure: https://issues.apache.org/jira/browse/HADOOP-19627, will fix

@ahmarsuhail ahmarsuhail merged commit 69d4c64 into apache:trunk Jul 18, 2025
4 checks passed
ahmarsuhail added a commit that referenced this pull request Jul 18, 2025
ahmarsuhail added a commit to ahmarsuhail/hadoop that referenced this pull request Jul 18, 2025
ahmarsuhail added a commit that referenced this pull request Jul 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants