HBASE-29073 StochasticLoadBalancer will always run the balancer on st…

…artup because of uninitialized sumMultiplier (#6641) (#6650) Signed-off-by: Nick Dimiduk <[email protected]> Co-authored-by: Ray Mattingly <[email protected]>
apache · Jan 31, 2025 · cb7e46a · cb7e46a
1 parent 2ac7ce6
commit cb7e46a
Showing 1 changed file with 6 additions and 3 deletions.
diff --git a/...-server/src/main/java/org/apache/hadoop/hbase/master/balancer/StochasticLoadBalancer.java b/...-server/src/main/java/org/apache/hadoop/hbase/master/balancer/StochasticLoadBalancer.java
@@ -442,14 +442,16 @@ boolean needsBalance(TableName tableName, BalancerClusterState cluster) {
     }
 
     double total = 0.0;
+    float localSumMultiplier = 0; // in case this.sumMultiplier is not initialized
     for (CostFunction c : costFunctions) {
       if (!c.isNeeded()) {
         LOG.trace("{} not needed", c.getClass().getSimpleName());
         continue;
       }
       total += c.cost() * c.getMultiplier();
+      localSumMultiplier += c.getMultiplier();
     }
-
+    sumMultiplier = localSumMultiplier;
     boolean balanced = (total / sumMultiplier < minCostNeedBalance);
     if (balanced) {
       if (isBalancerRejectionRecording) {
@@ -583,12 +585,13 @@ protected List<RegionPlan> balanceTable(TableName tableName,
     long startTime = EnvironmentEdgeManager.currentTime();
 
     initCosts(cluster);
-    sumMultiplier = 0;
+    float localSumMultiplier = 0;
     for (CostFunction c : costFunctions) {
       if (c.isNeeded()) {
-        sumMultiplier += c.getMultiplier();
+        localSumMultiplier += c.getMultiplier();
       }
     }
+    sumMultiplier = localSumMultiplier;
     if (sumMultiplier <= 0) {
       LOG.error("At least one cost function needs a multiplier > 0. For example, set "
         + "hbase.master.balancer.stochastic.regionCountCost to a positive value or default");