Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HBASE-29045 Support new async-profiler > 2.9 version #6614

Merged
merged 1 commit into from
Feb 6, 2025

Conversation

chaijunjie0101
Copy link
Contributor

Use the asprof script as default in order to support new async-profiler version.

@Apache-HBase

This comment has been minimized.

@Apache-HBase

This comment has been minimized.

@chaijunjie0101 chaijunjie0101 changed the title HBASE-29045 Script not found when enable profiler servlet HBASE-29045 SSupport new async-profiler > 2.9 version Jan 21, 2025
@chaijunjie0101 chaijunjie0101 changed the title HBASE-29045 SSupport new async-profiler > 2.9 version HBASE-29045 Support new async-profiler > 2.9 version Jan 21, 2025
@Apache-HBase

This comment has been minimized.

@Apache-HBase

This comment has been minimized.

@Apache-HBase

This comment has been minimized.

@Apache-HBase

This comment has been minimized.

@pankaj72981 pankaj72981 requested a review from apurtell January 21, 2025 07:01
Copy link
Contributor

@NihalJain NihalJain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mnpoonia
Copy link
Contributor

I also wonder if in future instead of using the script we can directly embed async profiler with hbase and use the JAVA API directly.
https://github.com/async-profiler/async-profiler/blob/master/docs/IntegratingAsyncProfiler.md#using-java-api

I am going through the doc and seems doable.

@chaijunjie0101
Copy link
Contributor Author

I also wonder if in future instead of using the script we can directly embed async profiler with hbase and use the JAVA API directly. https://github.com/async-profiler/async-profiler/blob/master/docs/IntegratingAsyncProfiler.md#using-java-api

I am going through the doc and seems doable.

thanks for reviewing, sounds good, we could use java api as a new feature..this MR just keep use the script.

@Apache-HBase
Copy link

🎊 +1 overall

Vote Subsystem Runtime Logfile Comment
+0 🆗 reexec 0m 33s Docker mode activated.
-0 ⚠️ yetus 0m 3s Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --author-ignore-list --blanks-eol-ignore-file --blanks-tabs-ignore-file --quick-hadoopcheck
_ Prechecks _
_ master Compile Tests _
+1 💚 mvninstall 4m 22s master passed
+1 💚 compile 0m 29s master passed
+1 💚 javadoc 0m 18s master passed
+1 💚 shadedjars 6m 51s branch has no errors when building our shaded downstream artifacts.
_ Patch Compile Tests _
+1 💚 mvninstall 3m 45s the patch passed
+1 💚 compile 0m 21s the patch passed
+1 💚 javac 0m 21s the patch passed
+1 💚 javadoc 0m 14s the patch passed
+1 💚 shadedjars 6m 33s patch has no errors when building our shaded downstream artifacts.
_ Other Tests _
+1 💚 unit 1m 8s hbase-http in the patch passed.
25m 32s
Subsystem Report/Notes
Docker ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6614/4/artifact/yetus-jdk17-hadoop3-check/output/Dockerfile
GITHUB PR #6614
Optional Tests javac javadoc unit compile shadedjars
uname Linux a6584708d57a 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision master / 522c0c5
Default Java Eclipse Adoptium-17.0.11+9
Test Results https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6614/4/testReport/
Max. process+thread count 413 (vs. ulimit of 30000)
modules C: hbase-http U: hbase-http
Console output https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6614/4/console
versions git=2.34.1 maven=3.9.8
Powered by Apache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase
Copy link

🎊 +1 overall

Vote Subsystem Runtime Logfile Comment
+0 🆗 reexec 0m 29s Docker mode activated.
_ Prechecks _
+1 💚 dupname 0m 0s No case conflicting files found.
+0 🆗 codespell 0m 0s codespell was not available.
+0 🆗 detsecrets 0m 0s detect-secrets was not available.
+1 💚 @author 0m 0s The patch does not contain any @author tags.
+1 💚 hbaseanti 0m 0s Patch does not have any anti-patterns.
_ master Compile Tests _
+1 💚 mvninstall 3m 41s master passed
+1 💚 compile 0m 32s master passed
+1 💚 checkstyle 0m 11s master passed
+1 💚 spotbugs 0m 31s master passed
+1 💚 spotless 0m 45s branch has no errors when running spotless:check.
_ Patch Compile Tests _
+1 💚 mvninstall 3m 0s the patch passed
+1 💚 compile 0m 22s the patch passed
+1 💚 javac 0m 22s the patch passed
+1 💚 blanks 0m 0s The patch has no blanks issues.
-0 ⚠️ checkstyle 0m 9s /results-checkstyle-hbase-http.txt hbase-http: The patch generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0)
+1 💚 spotbugs 0m 30s the patch passed
+1 💚 hadoopcheck 11m 47s Patch does not cause any errors with Hadoop 3.3.6 3.4.0.
+1 💚 spotless 0m 44s patch has no errors when running spotless:check.
_ Other Tests _
+1 💚 asflicense 0m 10s The patch does not generate ASF License warnings.
29m 58s
Subsystem Report/Notes
Docker ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6614/4/artifact/yetus-general-check/output/Dockerfile
GITHUB PR #6614
Optional Tests dupname asflicense javac spotbugs checkstyle codespell detsecrets compile hadoopcheck hbaseanti spotless
uname Linux 004cbee470b9 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision master / 522c0c5
Default Java Eclipse Adoptium-17.0.11+9
Max. process+thread count 83 (vs. ulimit of 30000)
modules C: hbase-http U: hbase-http
Console output https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6614/4/console
versions git=2.34.1 maven=3.9.8 spotbugs=4.7.3
Powered by Apache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

@pankaj72981 pankaj72981 merged commit 5b66a53 into apache:master Feb 6, 2025
1 check passed
pankaj72981 pushed a commit that referenced this pull request Feb 6, 2025
Signed-off-by: Nihal Jain <[email protected]>
Signed-off-by: Pankaj Kumar<[email protected]>
Reviewed-by: Aman Poonia <[email protected]>
(cherry picked from commit 5b66a53)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants