Skip to content

HBASE-29328: Implement new HBase command: refresh_hfiles #7149

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 13 commits into
base: HBASE-29081
Choose a base branch
from
Draft

HBASE-29328: Implement new HBase command: refresh_hfiles #7149

wants to merge 13 commits into from
+654 −4

Conversation

sharmaar12
Copy link

No description provided.

@sharmaar12 sharmaar12 marked this pull request as draft July 10, 2025 15:33
@Apache-HBase

This comment has been minimized.

Sign in to view
@Apache-HBase

This comment has been minimized.

Sign in to view
@Apache-HBase

This comment has been minimized.

Sign in to view
@Apache-HBase

This comment has been minimized.

Sign in to view
@Apache-HBase

This comment has been minimized.

Sign in to view
@Apache-HBase

This comment has been minimized.

Sign in to view
@Apache-HBase

This comment has been minimized.

Sign in to view
@Apache-HBase

This comment has been minimized.

Sign in to view
@Apache-HBase
Copy link

💔 -1 overall

Vote Subsystem Runtime Logfile Comment
+0 🆗 reexec 0m 32s Docker mode activated.
_ Prechecks _
+1 💚 dupname 0m 1s No case conflicting files found.
+0 🆗 codespell 0m 0s codespell was not available.
+0 🆗 detsecrets 0m 0s detect-secrets was not available.
+0 🆗 buf 0m 0s buf was not available.
+0 🆗 buf 0m 0s buf was not available.
+1 💚 @author 0m 0s The patch does not contain any @author tags.
+1 💚 hbaseanti 0m 0s Patch does not have any anti-patterns.
_ HBASE-29081 Compile Tests _
+0 🆗 mvndep 0m 11s Maven dependency ordering for branch
+1 💚 mvninstall 3m 18s HBASE-29081 passed
+1 💚 compile 5m 39s HBASE-29081 passed
+1 💚 checkstyle 1m 40s HBASE-29081 passed
+1 💚 spotbugs 5m 58s HBASE-29081 passed
+1 💚 spotless 0m 47s branch has no errors when running spotless:check.
_ Patch Compile Tests _
+0 🆗 mvndep 0m 12s Maven dependency ordering for patch
+1 💚 mvninstall 3m 4s the patch passed
+1 💚 compile 5m 37s the patch passed
+1 💚 cc 5m 37s the patch passed
+1 💚 javac 5m 37s the patch passed
+1 💚 blanks 0m 0s The patch has no blanks issues.
-0 ⚠️ checkstyle 0m 14s /buildtool-patch-checkstyle-hbase-server.txt The patch fails to run checkstyle in hbase-server
-0 ⚠️ rubocop 0m 19s /results-rubocop.txt The patch generated 6 new + 444 unchanged - 0 fixed = 450 total (was 444)
+1 💚 spotbugs 6m 30s the patch passed
+1 💚 hadoopcheck 12m 14s Patch does not cause any errors with Hadoop 3.3.6 3.4.0.
+1 💚 hbaseprotoc 2m 11s the patch passed
-1 ❌ spotless 0m 21s patch has 21 errors when running spotless:check, run spotless:apply to fix.
_ Other Tests _
+1 💚 asflicense 0m 43s The patch does not generate ASF License warnings.
59m 7s
Subsystem Report/Notes
Docker ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7149/5/artifact/yetus-general-check/output/Dockerfile
GITHUB PR #7149
JIRA Issue HBASE-29328
Optional Tests dupname asflicense javac spotbugs checkstyle codespell detsecrets compile hadoopcheck hbaseanti spotless cc buflint bufcompat hbaseprotoc rubocop
uname Linux c3628d24e4ed 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision HBASE-29081 / d465aa3
Default Java Eclipse Adoptium-17.0.11+9
spotless https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7149/5/artifact/yetus-general-check/output/patch-spotless.txt
Max. process+thread count 86 (vs. ulimit of 30000)
modules C: hbase-protocol-shaded hbase-client hbase-server hbase-thrift hbase-shell U: .
Console output https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7149/5/console
versions git=2.34.1 maven=3.9.8 spotbugs=4.7.3 rubocop=1.37.1
Powered by Apache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase
Copy link

💔 -1 overall

Vote Subsystem Runtime Logfile Comment
+0 🆗 reexec 0m 36s Docker mode activated.
-0 ⚠️ yetus 0m 4s Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --author-ignore-list --blanks-eol-ignore-file --blanks-tabs-ignore-file --quick-hadoopcheck
_ Prechecks _
_ HBASE-29081 Compile Tests _
+0 🆗 mvndep 0m 45s Maven dependency ordering for branch
+1 💚 mvninstall 3m 36s HBASE-29081 passed
+1 💚 compile 2m 36s HBASE-29081 passed
+1 💚 javadoc 1m 34s HBASE-29081 passed
+1 💚 shadedjars 5m 56s branch has no errors when building our shaded downstream artifacts.
_ Patch Compile Tests _
+0 🆗 mvndep 0m 13s Maven dependency ordering for patch
+1 💚 mvninstall 3m 5s the patch passed
+1 💚 compile 2m 33s the patch passed
+1 💚 javac 2m 33s the patch passed
+1 💚 javadoc 1m 35s the patch passed
+1 💚 shadedjars 5m 54s patch has no errors when building our shaded downstream artifacts.
_ Other Tests _
+1 💚 unit 0m 33s hbase-protocol-shaded in the patch passed.
+1 💚 unit 1m 33s hbase-client in the patch passed.
-1 ❌ unit 235m 52s /patch-unit-hbase-server.txt hbase-server in the patch failed.
+1 💚 unit 7m 36s hbase-thrift in the patch passed.
+1 💚 unit 8m 11s hbase-shell in the patch passed.
287m 38s
Subsystem Report/Notes
Docker ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7149/5/artifact/yetus-jdk17-hadoop3-check/output/Dockerfile
GITHUB PR #7149
JIRA Issue HBASE-29328
Optional Tests javac javadoc unit compile shadedjars
uname Linux dcad7b34027f 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision HBASE-29081 / d465aa3
Default Java Eclipse Adoptium-17.0.11+9
Test Results https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7149/5/testReport/
Max. process+thread count 5208 (vs. ulimit of 30000)
modules C: hbase-protocol-shaded hbase-client hbase-server hbase-thrift hbase-shell U: .
Console output https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7149/5/console
versions git=2.34.1 maven=3.9.8
Powered by Apache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

Kota-SH
Kota-SH reviewed Jul 29, 2025
View reviewed changes
hbase-protocol-shaded/src/main/protobuf/server/master/Master.proto
@@ -796,6 +796,17 @@ message ModifyColumnStoreFileTrackerResponse {
optional uint64 proc_id = 1;
}

message RefreshHFilesRequest {
optional TableName table_Name = 1;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
optional TableName table_Name = 1;
optional TableName table_name = 1;

hbase-client/src/main/java/org/apache/hadoop/hbase/client/Admin.java

/**
* Refresh HFiles for the table
* @param tableName table to refresh HFiles for
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add @ Return to the java doc

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Kota-SH Kota-SH Kota-SH left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sharmaar12 @Apache-HBase @Kota-SH