Skip to content

HIVE-29186: Compactor workers should be revoked only if running in me… #6068

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
+26 −8
Open

HIVE-29186: Compactor workers should be revoked only if running in me… #6068

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
68d5135
HIVE-29186: Compactor workers should be revoked only if running in me…
tanishq-chugh Sep 9, 2025
e075535
Update TestInitiator.recoverFailedLocalWorkers test as per the new logic
tanishq-chugh Sep 10, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion ql/src/java/org/apache/hadoop/hive/ql/txn/compactor/Initiator.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -236,7 +236,10 @@ private TableOptimizer instantiateTableOptimizer(String className) {
}

private void recoverFailedCompactions(boolean remoteOnly) throws MetaException {
if (!remoteOnly) txnHandler.revokeFromLocalWorkers(ServerUtils.hostname());
if (!remoteOnly &&
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tanishq-chugh we should drop HIVE_METASTORE_RUNWORKER_IN and not allow to run workers on HMS

MetastoreConf.getVar(conf, MetastoreConf.ConfVars.HIVE_METASTORE_RUNWORKER_IN).equals("metastore")) {
txnHandler.revokeFromLocalWorkers(ServerUtils.hostname());
}
txnHandler.revokeTimedoutWorkers(HiveConf.getTimeVar(conf,
HiveConf.ConfVars.HIVE_COMPACTOR_WORKER_TIMEOUT, TimeUnit.MILLISECONDS));
}
Expand Down
29 changes: 22 additions & 7 deletions ql/src/test/org/apache/hadoop/hive/ql/txn/compactor/TestInitiator.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,9 @@
import org.apache.hadoop.hive.metastore.api.Table;
import org.apache.hadoop.hive.metastore.api.hive_metastoreConstants;
import org.apache.hadoop.hive.metastore.conf.MetastoreConf;
import org.apache.hadoop.hive.metastore.txn.TxnHandler;
import org.apache.hadoop.hive.metastore.txn.TxnUtils;
import org.apache.hadoop.hive.metastore.txn.entities.CompactionInfo;
import org.junit.After;
import org.junit.Assert;
import org.junit.Test;
Expand Down Expand Up @@ -82,25 +84,38 @@ public void recoverFailedLocalWorkers() throws Exception {
rqst = new CompactionRequest("default", "rflw2", CompactionType.MINOR);
txnHandler.compact(rqst);

txnHandler.findNextToCompact(aFindNextCompactRequest(ServerUtils.hostname() + "-193892", WORKER_VERSION));
txnHandler.findNextToCompact(aFindNextCompactRequest("nosuchhost-193892", WORKER_VERSION));
CompactionInfo ci1 = txnHandler.findNextToCompact(
aFindNextCompactRequest(ServerUtils.hostname() + "-193892", WORKER_VERSION));
CompactionInfo ci2 = txnHandler.findNextToCompact(
aFindNextCompactRequest("nosuchhost-193892", WORKER_VERSION));

startInitiator();

ShowCompactResponse rsp = txnHandler.showCompact(new ShowCompactRequest());
List<ShowCompactResponseElement> compacts = rsp.getCompacts();
Assert.assertEquals(2, compacts.size());
boolean sawInitiated = false;
int numWorkingCompactions = 0;
for (ShowCompactResponseElement c : compacts) {
if (c.getState().equals("working")) {
Assert.assertEquals("nosuchhost-193892", c.getWorkerid());
} else if (c.getState().equals("initiated")) {
sawInitiated = true;
numWorkingCompactions++;
} else {
Assert.fail("Unexpected state");
}
}
Assert.assertTrue(sawInitiated);
Assert.assertEquals(2, numWorkingCompactions);

// Simulating nosuchhost-193892 worker completes compaction
txnHandler.markCompacted(ci2);
txnHandler.markCleaned(ci2);

rsp = txnHandler.showCompact(new ShowCompactRequest());
Assert.assertTrue(TxnHandler.SUCCEEDED_RESPONSE.equals(rsp.getCompacts().get(1).getState()));
Assert.assertTrue(TxnHandler.WORKING_RESPONSE.equals(rsp.getCompacts().get(0).getState()));

txnHandler.revokeTimedoutWorkers(0);

rsp = txnHandler.showCompact(new ShowCompactRequest());
Assert.assertTrue(TxnHandler.INITIATED_RESPONSE.equals(rsp.getCompacts().get(0).getState()));
}

@Test
Expand Down
Loading