HIVE-29191: Gracefully Handle Removed Configuration Properties in Hiv… #6073
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e 4 to Avoid Job Failures
zabetak
reviewed
Sep 11, 2025
Comment on lines
+7269
to
+7272
| public static String generateRemovedWarning() { | ||
| return "This config does not exist in the current version of Hive. Consider removing this config."; | ||
| } | ||
|
|
There was a problem hiding this comment.
There are better ways to log warning about deprecated/removed properties. See: org.apache.hadoop.conf.Configuration#addDeprecation
There was a problem hiding this comment.
I checked the method addDeprecation. This particular method takes oldKeys and newKeys(which are replacing the oldKeys) and it also has a null check to make sure newKeys are not null. Now since we have removed the properties there are no newKeys in our case making the method unusable for us.
Do let me know in case there is some other way to use the same functionality.
asf-ci-hive
added
tests pending
tests unstable
and removed
tests passed
tests pending
labels
vikramahuja1001
force-pushed
the
RemovedConfigs
branch
from
699397f to
950a048
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…e 4 to Avoid Job Failures
What changes were proposed in this pull request?
Why are the changes needed?
Does this PR introduce any user-facing change?
How was this patch tested?