HIVE-29215: Fix owner info for view in authorizable events for alter … #6087
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
asf-ci-hive
added
tests pending
tests unstable
tests passed
and removed
tests unstable
tests pending
labels
|
dengzhhu653
reviewed
Sep 29, 2025
| rootTasks.add(TaskFactory.get(new DDLWork(getInputs(), getOutputs(), desc))); | ||
| DDLUtils.addDbAndTableToOutputs(getDatabase(viewName.getDb()), viewName, TableType.VIRTUAL_VIEW, false, | ||
| null, outputs); | ||
| DDLUtils.addDbAndTableToOutputs(getDatabase(viewName.getDb()), oldView, outputs); |
There was a problem hiding this comment.
I don't get it, before this fix DDLUtils.addDbAndTableToOutputs will create a dummy table based on viewName, it has the same db and table with the oldView, why it doesn't work before?
There was a problem hiding this comment.
The viewName has type TableName, which has dbname and table name. So the HivePrivilegeObject will be constructed with the current user as the owner of the view. This is incorrect behavior.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…view query
What changes were proposed in this pull request?
Fixed owner info
Why are the changes needed?
Owner info incorrect in authorizable events
Does this PR introduce any user-facing change?
No
How was this patch tested?
Remote cluster