Skip to content

Conversation

@soumyakanti3578
Copy link
Contributor

What changes were proposed in this pull request?

Upgraded checkstyle version to 11.1.0.

Why are the changes needed?

https://issues.apache.org/jira/browse/HIVE-29239

Does this PR introduce any user-facing change?

No

How was this patch tested?

mvn checkstyle:checkstyle -Pitests

Copy link
Member

@zabetak zabetak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes LTTM! Out of curiosity why did you have to modify some of the iceberg files? I suppose that new version catches some violations that were previously missed.

@soumyakanti3578
Copy link
Contributor Author

@zabetak Yes that's my understanding too!

Btw, I noticed that hive-storage-api still uses checkstyle-9.3. This is because it's parent pom is not the root pom, so we don't use the root pom's maven-eclipse-plugin. I plan to enforce checkstyle-11.1.0 there tomorrow, so please don't merge this PR right now.

@sonarqubecloud
Copy link

sonarqubecloud bot commented Oct 3, 2025

@soumyakanti3578
Copy link
Contributor Author

@zabetak This is ready to be merged, if you're okay with the changes. I had to upgrade checkstyle in storage-api and standalone-metastore too.

@zabetak zabetak merged commit 0e8749e into apache:master Oct 6, 2025
2 checks passed
@zabetak
Copy link
Member

zabetak commented Oct 6, 2025

Thanks for the PR @soumyakanti3578 !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants