fix #5138

[sramazzina]

fix #5138 Project Dialog, minor layout issues needs to be fixed

---

Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

• Run mvn clean install apache-rat:check to make sure basic checks pass. A more thorough check will be performed on your pull request automatically.
• If you have a group of commits related to the same change, please squash your commits into one and force push your branch using git rebase -i.
• Mention the appropriate issue in your description (for example: addresses #123), if applicable.

To make clear that you license your contribution under the Apache License Version 2.0, January 2004
you have to acknowledge this by using the following check-box.

• I hereby declare this contribution to be licensed under the Apache License Version 2.0, January 2004
• In any other case, please file an Apache Individual Contributor License Agreement.

[hansva]

Did you just revert all my changes?
So that margin was added for the scrollbar, if you make it smaller a scrollbar will appear.
If that margin wasn't there it would overlap the components

[sramazzina]

The vertical/horizontal scrollbar are set for the only for the variable table. I was unaware that these changes was set by you but with your changes, if in the variables' table you have very long variables' values (for example we have email messages templates as variable values), the width of the dialog exceeds the visible area of the screen and you are unable to resize it. With our changes that case makes the horizontal bar of the table appear so we can scroll horizontally and the dialog keeps a consistent size. Moreover dialog's left and right margins are consistent. I think is much better

[sramazzina]

Here it is a sample of the new dialog's layout with really long variables' values

[hansva]

Alright,
But then we can add horizontal scroll on the tableview.
The problem I was solving is

About the table view...
That's another problem I am working on in my GUI proposals.
I hate the fact that those table cells claim infinite space so I am working on an "overflow"

[sramazzina]

About your first picture, IMHO having the dialog with a size that does't display the the variables' table is not properly correct because table's content is part of the project configuration therefore I'm personally not in favor of adding a vertical scrollbar not only for this case but in any case. But this is only my personal opinion. I think that the computer must give me the possibility to view the dialog in it's entirety even if very small

Instead of adding dialog's scrollbars I'm personally more in favor of redistributing the upper input fields over a set of tabs to reduce their height.

About the second issue, that's a good point but is not the case of the project's dialog as far as I remember.

[hansva]

While I do agree on that point,
It's the same as the vertical issue you had. you could also say well if it doesn't fit then it doesn't fit.
So it should at least support that use case. There are plenty of people using remote desktop with weird resolutions to quickly fix a thing

[sramazzina]

I will add the vertical scrollbar

[hansva]

using my original code and adding fdVariables.width = 300; to the wVariables formdata fixes everything I think

[sramazzina]

Let me have a look and I'll let you know

[hansva]

closing this in favor of #5171