Skip to content

feat: implement transform ResultType #132

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

zhjwpku
Copy link
Collaborator

@zhjwpku zhjwpku commented Jun 29, 2025

No description provided.

@wgtmac
Copy link
Member

wgtmac commented Jun 29, 2025

  Connection #0 to host www.apache.org left intact

  Issue another request to this URL:
  'https://archive.apache.org/dist/thrift/0.20.0/thrift-0.20.0.tar.gz'

  timeout on name lookup is not supported

  Host archive.apache.org:443 was resolved.

We have seen quite a lot timeout from downloading thrift-0.20.0. Should we fix this in the Arrow repo to use more stable URL? @lidavidm @raulcd

@wgtmac
Copy link
Member

wgtmac commented Jun 29, 2025

cc @gty404

case TypeId::kUuid:
case TypeId::kFixed:
case TypeId::kBinary:
return std::make_shared<IntType>();
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you need to define a static variable to avoid creating a new object every time, or add a singleton to the corresponding type? The following return values are also similar.

Copy link
Collaborator Author

@zhjwpku zhjwpku Jun 30, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've always wanted to add a singleton for each primitive type. If we reach a consensus, I can create a separate PR to implement that. WDYT @wgtmac @lidavidm @gty404 @mapleFU @Fokko @raulcd

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 Sorry - I had also meant to but as you can see recently I don't have the time.

@raulcd
Copy link
Member

raulcd commented Jun 30, 2025

We have seen quite a lot timeout from downloading thrift-0.20.0. Should we fix this in the Arrow repo to use more stable URL? @lidavidm @raulcd

There is an issue and a WIP PR (some issues were being worked on)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants