Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make field repr explicit about optionality, add exception type #43

Merged
merged 2 commits into from
Feb 18, 2025
Merged

Make field repr explicit about optionality, add exception type #43

merged 2 commits into from
Feb 18, 2025

Conversation

lidavidm
Copy link
Member

@lidavidm lidavidm commented Feb 4, 2025

  • Fix some clang-tidy lints (virtual ~Foo() = default -> ~Foo() override = default, missing explicit)
  • Add iceberg::IcebergError instead of std::runtime_error
  • Make field repr explicitly put (optional)
  • Note current time complexity of field accessors

@lidavidm lidavidm marked this pull request as ready for review February 4, 2025 05:48
Fokko
Fokko approved these changes Feb 4, 2025
View reviewed changes
Copy link
Contributor

@Fokko Fokko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding the optional 👍

@lidavidm @Fokko
Update src/iceberg/schema_field.cc
79c0cc0 
Co-authored-by: Fokko Driesprong <[email protected]>
zhjwpku
zhjwpku approved these changes Feb 4, 2025
View reviewed changes
Copy link
Collaborator

@zhjwpku zhjwpku left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lidavidm
Copy link
Member Author

Any more comments here?

@wgtmac
Copy link
Member

wgtmac commented Feb 18, 2025

@Fokko @Xuanwo Could you help merge this? Thanks!

Xuanwo
Xuanwo approved these changes Feb 18, 2025
View reviewed changes
Copy link
Member

@Xuanwo Xuanwo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you all, I like the iceberg::IcebergError.

@Xuanwo Xuanwo merged commit 17c500a into apache:main Feb 18, 2025
6 checks passed
@lidavidm lidavidm deleted the schema2 branch February 18, 2025 08:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Fokko Fokko Fokko approved these changes

@wgtmac wgtmac wgtmac approved these changes

@Xuanwo Xuanwo Xuanwo approved these changes

@zhjwpku zhjwpku zhjwpku approved these changes

@mapleFU mapleFU mapleFU approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@lidavidm @wgtmac @Fokko @Xuanwo @zhjwpku @mapleFU