Build/link to Rust iceberg-c library #45
Conversation
|
Hi, @lidavidm, maybe we should link against the iceberg-rust cpp bindings? I'll prepare another PR to demonstrate how CXX works. |
| ${ICEBERG_INCLUDES}) | ||
| ${ICEBERG_INCLUDES} | ||
| SHARED_LINK_LIBS | ||
| IcebergC::iceberg_c_shared |
There was a problem hiding this comment.
Do we need to make iceberg library mainly interface-oriented and add a new iceberg-rust-cxx-binding library to plug in the implementation? It is still unclear to me the extent of plug-ability in this approach.
There was a problem hiding this comment.
It depends on if we want to use Rust definitions for things like data types too, or if we just want to use it to implement talking to catalogs etc.
There was a problem hiding this comment.
I think that leveraging rust library is a good approach to move fast. However, there are still users that don't have a rust toolchain, or do not want to add extra dependencies introduced by the rust library.
|
For sure, I just wanted to prove that the CMake work I did on the other side works properly. |
Requires apache/iceberg-rust#966 with changes from https://github.com/lidavidm/iceberg-rust/tree/add-c-binding.