feat: add name mapping #93
Conversation
| namespace { | ||
|
|
||
| // Helper function to join a list of field names with a dot | ||
| std::string JoinByDot(std::span<const std::string> parts) { |
There was a problem hiding this comment.
I guess you can use join_view for this too
There was a problem hiding this comment.
I tried it but it seems that Clang does not yet implement this.
| @@ -0,0 +1,61 @@ | |||
| /* | |||
There was a problem hiding this comment.
Should we install this header by removing the internal suffix? I don't see it being used in this PR, but in #94, it's included in visit_type.h, which is meant to be installed for type manipulation. If we don't install this header, it might lead to compilation issues.
There was a problem hiding this comment.
I was using it for the visitor but not it is not required. Let me remove it for now. I saw that you have added that in your PR.
| @@ -36,7 +37,6 @@ set(ICEBERG_SOURCES | |||
| transform.cc | |||
| transform_function.cc | |||
| type.cc | |||
| snapshot.cc | |||
There was a problem hiding this comment.
Not a CPP guy, but why is snapshot.cc removed here? 🤔
There was a problem hiding this comment.
It is duplicate at line 32 :)
No description provided.