Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bug] Transaction new requirements handling #1628

Closed
3 tasks
kevinjqliu opened this issue Feb 8, 2025 · 4 comments · Fixed by #1631
Closed
3 tasks

[bug] Transaction new requirements handling #1628

kevinjqliu opened this issue Feb 8, 2025 · 4 comments · Fixed by #1631

Comments

@kevinjqliu
Copy link
Contributor

Apache Iceberg version

None

Please describe the bug 🐞

Context:
#569 (comment)

existing_requirements = {type(requirement) for requirement in self._requirements}
for new_requirement in requirements:
if type(new_requirement) not in existing_requirements:
self._requirements = self._requirements + requirements

cc @ZENOTME

Willingness to contribute

  • I can contribute a fix for this bug independently
  • I would be willing to contribute a fix for this bug with guidance from the Iceberg community
  • I cannot contribute a fix for this bug at this time
@kevinjqliu
Copy link
Contributor Author

cc @Fokko @HonahX wanted to double check with yall

@HonahX
Copy link
Contributor

HonahX commented Feb 9, 2025

Good catch! That should be "new_requirement" instead

@kevinjqliu
Copy link
Contributor Author

@ZENOTME would you like to contribute this change?

@ZENOTME
Copy link
Contributor

ZENOTME commented Feb 9, 2025

@ZENOTME would you like to contribute this change?

Sure, I will send the fix pr later

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants