Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix new requirements handling #1631

Merged
merged 2 commits into from
Feb 9, 2025
Merged

fix new requirements handling #1631

merged 2 commits into from
Feb 9, 2025

Conversation

ZENOTME
Copy link
Contributor

@ZENOTME ZENOTME commented Feb 9, 2025

Resolve #1628.

@ZENOTME
Copy link
Contributor Author

ZENOTME commented Feb 9, 2025

cc @kevinjqliu @Fokko @HonahX

kevinjqliu
kevinjqliu approved these changes Feb 9, 2025
View reviewed changes
Copy link
Contributor

@kevinjqliu kevinjqliu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for catching this!

Fokko
Fokko approved these changes Feb 9, 2025
View reviewed changes
Copy link
Contributor

@Fokko Fokko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oof, good catch @ZENOTME

@Fokko @kevinjqliu
I feel lucky
99fd098 
Co-authored-by: Kevin Liu <[email protected]>
HonahX
HonahX approved these changes Feb 9, 2025
View reviewed changes
Copy link
Contributor

@HonahX HonahX left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for catching this!

@Fokko Fokko merged commit dd175aa into apache:main Feb 9, 2025
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kevinjqliu kevinjqliu kevinjqliu approved these changes

@Fokko Fokko Fokko approved these changes

@HonahX HonahX HonahX approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[bug] Transaction new requirements handling
4 participants
@ZENOTME @Fokko @kevinjqliu @HonahX