Remove field id constraint on add files #2662
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeroko
force-pushed
the
remove-field_id-constraint-on-add_files
branch
2 times, most recently
from
0b599c6 to
d580102
Compare
jeroko
force-pushed
the
remove-field_id-constraint-on-add_files
branch
from
d580102 to
1addf60
Compare
Fokko
reviewed
Oct 27, 2025
kevinjqliu
reviewed
Nov 4, 2025
Contributor
kevinjqliu
left a comment
kevinjqliu
left a comment
There was a problem hiding this comment.
Thanks for the PR! This is a great addition. Added a few comments
Comment on lines
2644
to
2647
Contributor
There was a problem hiding this comment.
i think we should at least check that the parquet field IDs align with the Iceberg field IDs
Author
There was a problem hiding this comment.
Hi @kevinjqliu, what kind of extra ID alignment do you expect that is not already covered by _check_schema_compatible ?
| `add_files` can work with Parquet files both with and without field IDs in their metadata: | ||
| - **Files with field IDs**: When field IDs are present in the Parquet metadata, they must match the corresponding field IDs in the Iceberg table schema. This is common for files generated by tools like Spark or when using or other libraries with explicit field ID metadata. | ||
| - **Files without field IDs**: When field IDs are absent, the table must have a [Name Mapping](https://iceberg.apache.org/spec/?h=name+mapping#name-mapping-serialization) to map field names to Iceberg field IDs. `add_files` will automatically create a Name Mapping based on the table's current schema if one doesn't already exist. | ||
| In both cases, a Name Mapping is created if the table doesn't have one, ensuring compatibility with various readers. |
Contributor
There was a problem hiding this comment.
For parquet files with field ID, i dont think we necessary need the name mapping if its aligned with the table schema field IDs
But we can address this separately
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale for this change
Closes #2131
The PR relaxes the constraint that prevented adding any file with field IDs, and replaces it with a constraint that prevents adding files which contain field IDs that are inconsistent with the field IDs of the table. If the field IDs are compatible, then they can be added safely, if not, they will be rejected.
Are these changes tested?
Yes
Are there any user-facing changes?
Yes