feat: support update for memory catalog #1002
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ZENOTME
force-pushed
the
memory_catalog_update
branch
from
35ac16d to
3c14f04
Compare
jonathanc-n
reviewed
Feb 24, 2025
| @@ -53,6 +53,30 @@ impl MemoryCatalog { | |||
| warehouse_location, | |||
| } | |||
| } | |||
|
|
|||
| fn new_metadata_location(&self, location: &str) -> String { | |||
There was a problem hiding this comment.
This should include version increment, and be in the format as defined in the spec.
There was a problem hiding this comment.
Thanks @ZENOTME for this pr. The reason we don't add update table support before is that currently the table transaction api is not complete yet, and we should not add this in catalog in such a way.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To add runnable update example #999, we should support update forthe memory catalog first.