feat(sqllogictest): Add sqllogictest schedule definition and parsing #1630
+277
−14
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Ok(Self::new(engines, steps)) | ||
| } | ||
|
|
||
| pub async fn run(mut self) -> anyhow::Result<()> { |
There was a problem hiding this comment.
Add a log about current schedule file?
crates/sqllogictest/src/schedule.rs
Outdated
| .ok_or_else(|| anyhow!("Engine {} not found", step.engine))?; | ||
|
|
||
| engine | ||
| .run_slt_file(&PathBuf::from(step.slt.clone())) |
There was a problem hiding this comment.
This maybe a potential issue, the file path is relative to testdata dir, but we could fix it later.
There was a problem hiding this comment.
Good point, added the relative path in the previous draft PR, but missed it here. https://github.com/apache/iceberg-rust/pull/1621/files#diff-26b82f60b13d2afef45d856281a6fae47fefd48a440613ddcdd27059aec7639bR145-R150
|
Build seems to be broken. Put out a fix for it. Need to rerun after #1635 |
| @@ -61,6 +51,16 @@ impl Engine for DataFusionEngine { | |||
| } | |||
|
|
|||
| impl DataFusionEngine { | |||
| pub async fn new(config: TomlTable) -> Result<Self> { | |||
There was a problem hiding this comment.
Why we move this out of trait?
liurenjie1024
approved these changes
Sep 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
What changes are included in this PR?
Are these changes tested?
Yes, through unit tests. Some parts, like parse engines, require integrations and will be tested once engine and catalog support is added as part of the sql logic tests.