-
Notifications
You must be signed in to change notification settings - Fork 209
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add pyspark DataFusion integration test #850
Conversation
54a482b
to
6709685
Compare
6709685
to
318ff77
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Great to see an example using datafusion's TableProvider
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, once the Cargo.toml change is made. Thanks :-)
abfd516
to
b6e171e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is so that both the datafusion integration and integration test crates can inherit the same version.
98cadea
to
be35fb1
Compare
It's a yes from me @gruuya - approved 🙂 |
Thank you @gruuya for working on this, and thank you @Fokko, @kevinjqliu, @liurenjie1024 and @sdd for the review. Sorry for the late, let's move! |
This tests propagation of all supported primitive types in an e2e manner.
Alternative to #825.