Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs: Add missing types to the spec v3 summary #12219

Merged
merged 2 commits into from
Feb 11, 2025
Merged

Conversation

wgtmac
Copy link
Member

@wgtmac wgtmac commented Feb 11, 2025

variant and geospatial types are recently added to the v3 spec but the summary is not updated in sync.

@github-actions github-actions bot added the Specification Issues that may introduce spec changes. label Feb 11, 2025
@wgtmac
Copy link
Member Author

wgtmac commented Feb 11, 2025

cc @szehon-ho @flyrain

Copy link
Collaborator

@szehon-ho szehon-ho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After checking https://iceberg.apache.org/contribute/#merging-pull-requests, I think this is fine with me. These are covered by existing votes already, and this is not functionally changing the spec.

That said, ill let a bit of time in case anyone disagrees here.

Copy link
Contributor

@ebyhr ebyhr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How about updating the following line as well?

Types `variant`, `unknown`, `timestamp_ns`, and `timestamptz_ns` are added in v3.

@nastra nastra merged commit 31e9dc7 into apache:main Feb 11, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Specification Issues that may introduce spec changes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants