Skip to content

Conversation

@kumarpritam863
Copy link
Contributor

Summary
This PR refactors the Committer implementation to remove its tight coupling with Kafka and provide users the flexibility to define their own coordinator election mechanism by implementing the Committer Interface. Currently, the coordinator is elected based on the lexicographically smallest source topic partition, which limits adaptability in different environments.

Changes Introduced

  1. Config is exposed which can be used to provide the implementation class.
  2. Dynamically loads the user's committer implementation with proper constructor parameters and extra configs in case needed for other settings.

@github-actions
Copy link

This pull request has been marked as stale due to 30 days of inactivity. It will be closed in 1 week if no further activity occurs. If you think that’s incorrect or this pull request requires a review, please simply write any comment. If closed, you can revive the PR at any time and @mention a reviewer or discuss it on the [email protected] list. Thank you for your contributions.

@github-actions github-actions bot added the stale label Jul 29, 2025
@kumarpritam863
Copy link
Contributor Author

@bryanck can we please take some decision on this. This will at least allow users to plug in their committer logic.

@github-actions github-actions bot removed the stale label Aug 6, 2025
@github-actions
Copy link

github-actions bot commented Sep 7, 2025

This pull request has been marked as stale due to 30 days of inactivity. It will be closed in 1 week if no further activity occurs. If you think that’s incorrect or this pull request requires a review, please simply write any comment. If closed, you can revive the PR at any time and @mention a reviewer or discuss it on the [email protected] list. Thank you for your contributions.

@github-actions github-actions bot added the stale label Sep 7, 2025
@kumarpritam863
Copy link
Contributor Author

@bryanck can we also take decision on this one as this will give freedom to users to plug their committers.

@github-actions github-actions bot removed the stale label Sep 15, 2025
@kumarpritam863
Copy link
Contributor Author

@ajantha-bhat can you please review this.

@github-actions
Copy link

This pull request has been marked as stale due to 30 days of inactivity. It will be closed in 1 week if no further activity occurs. If you think that’s incorrect or this pull request requires a review, please simply write any comment. If closed, you can revive the PR at any time and @mention a reviewer or discuss it on the [email protected] list. Thank you for your contributions.

@github-actions github-actions bot added the stale label Oct 17, 2025
@kumarpritam863
Copy link
Contributor Author

@bryanck is there any update on this one?

@github-actions github-actions bot removed the stale label Oct 22, 2025
@github-actions
Copy link

This pull request has been marked as stale due to 30 days of inactivity. It will be closed in 1 week if no further activity occurs. If you think that’s incorrect or this pull request requires a review, please simply write any comment. If closed, you can revive the PR at any time and @mention a reviewer or discuss it on the [email protected] list. Thank you for your contributions.

@github-actions github-actions bot added the stale label Nov 21, 2025
@kumarpritam863
Copy link
Contributor Author

@bryanck can we please take a call on this as this is getting marked stale by GitHub repetitively.

@github-actions github-actions bot removed the stale label Nov 22, 2025
@kumarpritam863
Copy link
Contributor Author

Handled by PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants