Error handling with DLQ support #14618
Open
+188
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
manuzhang
reviewed
Nov 20, 2025
| record.kafkaPartition(), | ||
| record.kafkaOffset()), | ||
| e); | ||
| String.format( |
manuzhang
reviewed
Nov 20, 2025
| import org.slf4j.Logger; | ||
| import org.slf4j.LoggerFactory; | ||
|
|
||
| public class DlqReporter implements AutoCloseable { |
Member
There was a problem hiding this comment.
Please add some comments for this class.
Member
There was a problem hiding this comment.
Is this intended to be public?
manuzhang
reviewed
Nov 20, 2025
| String key = (data.key()==null) ? null : data.key().toString(); | ||
| String value = (data.value()==null) ? null : data.value().toString(); | ||
| try { | ||
| LOG.info("Published DLQ record {}", value); |
Member
There was a problem hiding this comment.
Do we need to log every value to DLQ?
Member
|
@devendra-nr Please add some tests for your changes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reopening #13135