Refactor SnapshotAncestryValidator #14650
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove the unnecessary extension of the Function interface and simplify to return a primitive boolean. Use the meaningful interface name. Change-Id: I430616b433c272abc7869dc62d92ead26de50fee
Contributor
Author
|
@danielcweeks @rdblue Could you please take a look? |
danielcweeks
approved these changes
Dec 1, 2025
Contributor
danielcweeks
left a comment
danielcweeks
left a comment
There was a problem hiding this comment.
LGTM, Thanks @aiborodin! We haven't done a release, so I think this is ok to change for revapi, but need to check whether it was ported to the 1.10.x branch for the patch release.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Simplify the return type to a primitive boolean by removing the
Functioninterface.Change the interface name to
validate()instead ofapply().