Skip to content

Conversation

@ebyhr
Copy link
Contributor

@ebyhr ebyhr commented Nov 25, 2025

Continuation of #9231

Screenshot 2025-11-25 at 13 37 30

@github-actions github-actions bot added the docs label Nov 25, 2025
Copy link
Contributor

@kevinjqliu kevinjqliu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM minor comment on phrasing

Here's the definition of gc.enabled property:

public static final String GC_ENABLED = "gc.enabled";
public static final boolean GC_ENABLED_DEFAULT = true;

And where its used

| history.expire.max-snapshot-age-ms | 432000000 (5 days) | Default max age of snapshots to keep on the table and all of its branches while expiring snapshots |
| history.expire.min-snapshots-to-keep | 1 | Default min number of snapshots to keep on the table and all of its branches while expiring snapshots |
| history.expire.max-ref-age-ms | `Long.MAX_VALUE` (forever) | For snapshot references except the `main` branch, default max age of snapshot references to keep while expiring snapshots. The `main` branch never expires. |
| gc.enabled | true | Disable garbage collection operations such as expiring snapshots or removing orphan files |
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
| gc.enabled | true | Disable garbage collection operations such as expiring snapshots or removing orphan files |
| gc.enabled | true | Allows garbage collection operations such as expiring snapshots and removing orphan files |

nit: using "Disable" here is confusing, esp the property name has "enabled" and defaults to true

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: please change the PR description accordingly.

@kevinjqliu kevinjqliu merged commit 47d5f50 into apache:main Nov 25, 2025
4 checks passed
@kevinjqliu
Copy link
Contributor

Thanks @ebyhr and thanks everyone for the review

@ebyhr ebyhr deleted the ebi/docs-gc branch November 26, 2025 13:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants