IGNITE-24309 Decrease number of slots in HeapLockManager in tests #5118
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ivanzlenko
reviewed
Jan 28, 2025
| * | ||
| * @param nodeName Name of the node. Must not be {@code null}. | ||
| * @param configStr Optional node configuration. | ||
| * @return Completable future that resolves into an Ignite node after all components are started and the cluster initialization is |
There was a problem hiding this comment.
Missing param workDir here.
| @@ -206,4 +243,8 @@ private static ConfigDocument applyTestDefault(ConfigDocument document, String p | |||
| return document.withValueText(path, value); | |||
| } | |||
| } | |||
|
|
|||
| private static String toDoubleQuotedString(Object obj) { | |||
There was a problem hiding this comment.
Let's add this to StringUtils, 'cause we have quite a lot of places where we can have a use of this method.
|
Closing as this is not relevant anymore. However, part of the work that was done in this PR was moved to #5265. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://issues.apache.org/jira/browse/IGNITE-24309