IGNITE-24021 Sql. Merged duplicate code in QualifiedName and IgniteNameUtils #5218
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xtern
force-pushed
the
ignite-24021
branch
3 times, most recently
from
642de15 to
83dfbfd
Compare
xtern
changed the title
xtern
commented
Feb 14, 2025
modules/api/src/main/java/org/apache/ignite/lang/util/IgniteNameUtils.java
Outdated
Show resolved
Hide resolved
xtern
commented
Feb 14, 2025
modules/api/src/test/java/org/apache/ignite/table/QualifiedNameTest.java
Show resolved
Hide resolved
lowka
reviewed
Feb 14, 2025
| return new QualifiedName(schemaName == null ? DEFAULT_SCHEMA_NAME : schemaName, objectName); | ||
| } | ||
|
|
||
|
|
There was a problem hiding this comment.
I think this empty line is unnecessary
AMashenkov
reviewed
Feb 17, 2025
modules/api/src/main/java/org/apache/ignite/lang/util/IgniteNameUtils.java
Outdated
Show resolved
Hide resolved
AMashenkov
reviewed
Feb 17, 2025
modules/api/src/main/java/org/apache/ignite/lang/util/IgniteNameUtils.java
Outdated
Show resolved
Hide resolved
AMashenkov
reviewed
Feb 17, 2025
modules/api/src/main/java/org/apache/ignite/lang/util/IgniteNameUtils.java
Show resolved
Hide resolved
AMashenkov
approved these changes
Feb 17, 2025
AMashenkov
approved these changes
Feb 18, 2025
lowka
approved these changes
Feb 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://issues.apache.org/jira/browse/IGNITE-24021
QualifiedNamemoved toIgniteNameUtils.IgniteNameUtils.parseSimpleName(name)renamed toparseIdentifier(identifier)and doesn't accept null/empty names anymore.List<String> IgniteNameUtils.parseName(name)for parsing fully qualified canonical names (this is used byQualifiedNameto parse input).quote(name)is now private, and its usage in the codebase has been replaced withquoteIfNeeded(name).