Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IGNITE-24512 Remove unnecessary dependencies and update outdated #5227

Merged
merged 4 commits into from
Feb 18, 2025

Conversation

ygerzhedovich
Copy link
Contributor

Thank you for submitting the pull request.

To streamline the review process of the patch and ensure better code quality
we ask both an author and a reviewer to verify the following:

The Review Checklist

  • Formal criteria: TC status, codestyle, mandatory documentation. Also make sure to complete the following:
    - There is a single JIRA ticket related to the pull request.
    - The web-link to the pull request is attached to the JIRA ticket.
    - The JIRA ticket has the Patch Available state.
    - The description of the JIRA ticket explains WHAT was made, WHY and HOW.
    - The pull request title is treated as the final commit message. The following pattern must be used: IGNITE-XXXX Change summary where XXXX - number of JIRA issue.
  • Design: new code conforms with the design principles of the components it is added to.
  • Patch quality: patch cannot be split into smaller pieces, its size must be reasonable.
  • Code quality: code is clean and readable, necessary developer documentation is added if needed.
  • Tests code quality: test set covers positive/negative scenarios, happy/edge cases. Tests are effective in terms of execution time and resources.

Notes

@ygerzhedovich ygerzhedovich changed the title IGNITE-24512 Uodate dependencies IGNITE-24512 Update dependencies Feb 14, 2025
Copy link
Contributor

@zstan zstan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why this changes "micronaut = "3.10.4"" have not been updated through dependabot ?
Description of issue and PR confusing, i suggest to expand it a bit

@ygerzhedovich
Copy link
Contributor Author

Why this changes "micronaut = "3.10.4"" have not been updated through dependabot ? Description of issue and PR confusing, i suggest to expand it a bit

Dependabot has some delay and seems the delay.

@ygerzhedovich ygerzhedovich changed the title IGNITE-24512 Update dependencies IGNITE-24512 Remove unnecessary dependencies and update outdated Feb 18, 2025
@ygerzhedovich ygerzhedovich merged commit f9ac8d0 into apache:main Feb 18, 2025
1 check passed
@ygerzhedovich ygerzhedovich deleted the ignite-24512 branch February 18, 2025 12:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants