IGNITE-22620 Implement ReplicaSafeTimeSyncRequest processing for zone replica #5258
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sanpwc
reviewed
Feb 21, 2025
| @@ -656,6 +660,41 @@ public void testScanCloseReplicaRequest() throws Exception { | |||
| assertDoesNotThrow(tx::commit); | |||
| } | |||
|
|
|||
| @Test | |||
| public void testReplicaSafeTimeSyncRequest() throws Exception { | |||
| // Prepare a single node cluster. | |||
There was a problem hiding this comment.
It's not a single node cluster))
sanpwc
reviewed
Feb 21, 2025
| // Create a table to work with. | ||
| createTable(node0, zoneName, "test_table"); | ||
|
|
||
| HybridTimestamp node0safeTimeBefore = node0.currentSafeTimeForZonePartition(zoneId, partId); |
There was a problem hiding this comment.
currentSafeTimeForZonePartition may fail with Missing resources for zone if you will call
ZonePartitionResources getZonePartitionResources(ZonePartitionId zonePartitionId) {
ZoneResources zoneResources = resourcesByZoneId.get(zonePartitionId.zoneId());
fast enough.
sanpwc
reviewed
Feb 21, 2025
| int partId = 0; | ||
|
|
||
| // Create a table to work with. | ||
| createTable(node0, zoneName, "test_table"); |
There was a problem hiding this comment.
Please adjust the test in a following way.
- Create zone
- ensure that safeTime was successfully adjusted. // It should be possible to adjust timestamp even if there's no tables in zone.
- Create table
- await table creation and ensure that safeTime was successfully adjusted.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JIRA Ticket: IGNITE-22620
The goal
The reason
The solution