Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IGNITE-24501 Introduce a separate disruptor pool for CMG #5260

Merged
merged 3 commits into from
Feb 21, 2025

Conversation

rpuch
Copy link
Contributor

@rpuch rpuch commented Feb 21, 2025

https://issues.apache.org/jira/browse/IGNITE-24501

  • a separate disruptor pool for CMG is introduced to make sure partition recovery does not get in the way of CMG commands execution
  • JoinReady command execution is made without a timeout to make join process more reliable
  • Naming of Raft disruptor threads is improved

* a separate disruptor pool for CMG is introduced to make sure partition recovery does not get in the way of CMG commands execution
* JoinReady command execution is made without a timeout to make join process more reliable
* Naming of Raft disruptor threads is improved
Copy link
Contributor

@Phillippko Phillippko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approved with minor comments

@@ -786,10 +789,12 @@ private CompletableFuture<CmgRaftService> startCmgRaftService(Set<String> nodeNa
clusterIdStore
),
this::onElectedAsLeader,
disruptorConfig,

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change

return List.of();
}
}
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let's add line in the end of file

@rpuch rpuch merged commit 3c747bd into apache:main Feb 21, 2025
1 check passed
@rpuch rpuch deleted the ignite-24501 branch February 21, 2025 09:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants