Skip to content
This repository has been archived by the owner on Feb 6, 2024. It is now read-only.

chore: add asf yaml #292

Merged
merged 2 commits into from
Dec 25, 2023
Merged

chore: add asf yaml #292

merged 2 commits into from
Dec 25, 2023

Conversation

chunshao90
Copy link
Contributor

Rationale

Add .asf.yaml.

Detailed Changes

Test Plan

No need.

@caicancai
Copy link
Member

caicancai commented Dec 22, 2023 •
edited
Loading

I think we should add a cli check for icense. I don’t know if horaedb currently has this measure.

@chunshao90
Copy link
Contributor Author

I think we should add a cli check for icense. I don’t know if horaedb currently has this measure.

license checker？

@caicancai
Copy link
Member

I think we should add a cli check for icense. I don’t know if horaedb currently has this measure.

license checker？

yes

tanruixiang
tanruixiang approved these changes Dec 25, 2023
View reviewed changes
Copy link
Member

@tanruixiang tanruixiang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@chunshao90
Copy link
Contributor Author

I think we should add a cli check for icense. I don’t know if horaedb currently has this measure.

License checker already exists in horaemeta.

@tanruixiang tanruixiang merged commit 393774a into apache:main Dec 25, 2023
3 checks passed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@tanruixiang tanruixiang tanruixiang approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@chunshao90 @caicancai @tanruixiang