Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(scripts): Fix the way the wait_manual_compact function parses the shell output #2191

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

limowang
Copy link
Collaborator

@limowang limowang commented Feb 6, 2025

… remote_command -t replica-server replica.query-compact shell command.

What problem does this PR solve?

#2190

What is changed and how does it work?

The commit 2d68748 changed the output format of the shell command remote_command -t replica-server replica.query-compact ${app_id}, which caused the wait_manual_compact function to still parse the output based on the original format, leading to incorrect behavior. It has now been fixed by modifying the parsing method.

… remote_command -t replica-server replica.query-compact shell command.
@limowang limowang changed the title Fix the way the wait_manual_compact function parses the output of the… fix(scripts): Fix the way the wait_manual_compact function parses the shell output Feb 6, 2025
@limowang
Copy link
Collaborator Author

The shell command remote_command -t replica-server replica.query-compact ${app_id} outputs in the following format in the latest version:
CALL [replica-server] [10.1.132.34:8171] succeed:
8 processed, 0 not found
[email protected]:8171@P : {"last_finish":"-","last_used_ms":"-","recent_enqueue_at":"-","recent_start_at":"-"}
[email protected]:8171@P : {"last_finish":"-","last_used_ms":"-","recent_enqueue_at":"-","recent_start_at":"-"}
[email protected]:8171@P : {"last_finish":"-","last_used_ms":"-","recent_enqueue_at":"-","recent_start_at":"-"}
[email protected]:8171@P : {"last_finish":"-","last_used_ms":"-","recent_enqueue_at":"-","recent_start_at":"-"}
[email protected]:8171@P : {"last_finish":"-","last_used_ms":"-","recent_enqueue_at":"-","recent_start_at":"-"}
[email protected]:8171@P : {"last_finish":"-","last_used_ms":"-","recent_enqueue_at":"-","recent_start_at":"-"}
[email protected]:8171@P : {"last_finish":"-","last_used_ms":"-","recent_enqueue_at":"-","recent_start_at":"-"}
[email protected]:8171@P : {"last_finish":"-","last_used_ms":"-","recent_enqueue_at":"-","recent_start_at":"-"}

Below is the output example from the previous version:
CALL [replica-server] [10.1.132.36:8171] succeed: 8 processed, 0 not found
[email protected]:8171@P : last finish at [-]
[email protected]:8171@P : last finish at [-]
[email protected]:8171@P : last finish at [-]
[email protected]:8171@P : last finish at [-]
[email protected]:8171@P : last finish at [-]
[email protected]:8171@P : last finish at [-]
[email protected]:8171@P : last finish at [-]
[email protected]:8171@P : last finish at [-]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant