Skip to content

Commit

Permalink
[RELEASE][PREPARATION] correction because it not need the profiles
Browse files Browse the repository at this point in the history
Signed-off-by: bertty <[email protected]>
  • Loading branch information
Bertty Contreras-Rojas authored and berttty committed Oct 12, 2021
1 parent c4ad143 commit 6b7b96d
Show file tree
Hide file tree
Showing 5 changed files with 49 additions and 9 deletions.
4 changes: 2 additions & 2 deletions .travis.yml
Original file line number Diff line number Diff line change
Expand Up @@ -86,8 +86,8 @@ before_script:
# - chmod +x ./docs/script/cibuild
script:
#- jdk_switcher use openjdk8
- mvn clean install -Pdistro,scala-11 "${mvn_opts[@]}" &> result.log
- mvn clean install -Pdistro,scala-12 "${mvn_opts[@]}" &>> result.log
#- mvn clean install -Pdistro,scala-11 "${mvn_opts[@]}" &> result.log
- mvn clean install "${mvn_opts[@]}" &>> result.log
#- mvn clean install -Pdistro,scala-13 "${mvn_opts[@]}" &>> result.log # This is not working for now because of Spark and Flink not supporting Scala 2.13
- cat /home/travis/build/apache/incubator-wayang/target/rat.txt || echo "file doesn't exist"
- tail -n 2000 result.log
Expand Down
10 changes: 5 additions & 5 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -60,16 +60,16 @@ If you need to rebuild Wayang, e.g., to use a different Scala version, you can s
1. Adapt the version variables (e.g., `spark.version`) in the main `pom.xml` file.
2. Build Wayang with the adapted versions.
```shell
$ mvn clean install -Pscala-{11,12}
$ mvn clean install
```
> **NOTE:** In current maven setup the version of scala are tie to the Java version, you can compile the profile `scala-11` with Java 8 and profile `scala-12` with Java 11
> **NOTE:** In current maven setup the version of scala are tie to the Java version, you can compile the profile `scala-11` with Java 8 and profile `scala-12` with Java 11

> **NOTE:** For compiling the code and testing the code it required to have installed hadoop in your machine
> **NOTE:** For compiling the code and testing the code it required to have installed hadoop in your machine

> **NOTE:** the `standalone` profile to fix Hadoop and Spark versions, so that Wayang apps do not explicitly need to declare the corresponding dependencies.
>
>
> Also, note the `distro` profile, which assembles a binary Wayang distribution.
To activate these profiles, you need to specify them when running maven, i.e.,
To activate these profiles, you need to specify them when running maven, i.e.,

```shell
mvn clean install -P<profile name>
Expand Down
2 changes: 1 addition & 1 deletion build.md
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@
Apache Wayang has different dependencies, for compiling, it needs to add some profile in the compilation to enable maven works properly.

```shell
mvn clean compile -P scala-11
mvn clean compile
```

The line before is because the plugin the Antlr is not needed in all the modules, as well it has happened with Scala language.
Expand Down
2 changes: 1 addition & 1 deletion jenkins.pom
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@
<parent>
<groupId>org.apache</groupId>
<artifactId>apache</artifactId>
<version>22</version>
<version>24</version>
</parent>

<groupId>org.apache.wayang</groupId>
Expand Down
40 changes: 40 additions & 0 deletions pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -858,6 +858,46 @@
<additionalparam>-Xdoclint:none</additionalparam>
</properties>
</profile>

<profile>
<id>apache-release</id>
<build>
<finalName>apache-${project.artifactId}-${project.version}-incubating</finalName>
<resources>
<resource>
<directory>${project.basedir}</directory>
<includes>
<include>DISCLAIMER</include>
<include>LICENSE</include>
<include>NOTICE</include>
<include>RELEASE_NOTES</include>
<include>README.md</include>
</includes>
</resource>
</resources>
<plugins>
<!-- Create a source-release artifact that contains the fully buildable
project directory source structure. This is the artifact which is
the official subject of any release vote. -->
<plugin>
<groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-assembly-plugin</artifactId>
<executions>
<execution>
<id>source-release-assembly</id>
<phase>package</phase>
<goals>
<goal>single</goal>
</goals>
<configuration>
<finalName>apache-${project.artifactId}-${project.version}-incubating</finalName>
</configuration>
</execution>
</executions>
</plugin>
</plugins>
</build>
</profile>
</profiles>

<dependencyManagement>
Expand Down

0 comments on commit 6b7b96d

Please sign in to comment.