-
Notifications
You must be signed in to change notification settings - Fork 187
Add implementation for XTable REST Service #704
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
87e0531
to
dada46e
Compare
vinishjail97
reviewed
May 5, 2025
xtable-service/src/main/java/org/apache/xtable/service/ConversionControllerFactory.java
Show resolved
Hide resolved
xtable-service/src/main/java/org/apache/xtable/service/ConversionControllerFactory.java
Outdated
Show resolved
Hide resolved
xtable-service/src/main/java/org/apache/xtable/service/ConversionResource.java
Outdated
Show resolved
Hide resolved
xtable-service/src/main/java/org/apache/xtable/service/ConversionResource.java
Show resolved
Hide resolved
xtable-service/src/main/java/org/apache/xtable/service/spark/SparkHolder.java
Outdated
Show resolved
Hide resolved
xtable-service/src/main/java/org/apache/xtable/service/utils/HudiMedataUtil.java
Outdated
Show resolved
Hide resolved
xtable-service/src/main/java/org/apache/xtable/service/utils/DeltaMetadataUtil.java
Outdated
Show resolved
Hide resolved
xtable-service/src/main/java/org/apache/xtable/service/utils/IcebergMetadataUtil.java
Outdated
Show resolved
Hide resolved
xtable-service/src/test/java/org/apache/xtable/service/TestConversionResource.java
Show resolved
Hide resolved
vinishjail97
reviewed
May 8, 2025
xtable-service/src/main/java/org/apache/xtable/service/ConversionService.java
Outdated
Show resolved
Hide resolved
xtable-service/src/main/java/org/apache/xtable/service/ConversionService.java
Outdated
Show resolved
Hide resolved
xtable-service/src/main/java/org/apache/xtable/service/spark/SparkHolder.java
Outdated
Show resolved
Hide resolved
vinishjail97
reviewed
May 9, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you re-base with the base PR and address remaining comments?
xtable-service/src/main/java/org/apache/xtable/service/ConversionService.java
Outdated
Show resolved
Hide resolved
xtable-service/src/main/java/org/apache/xtable/service/ConversionService.java
Outdated
Show resolved
Hide resolved
xtable-service/src/main/java/org/apache/xtable/service/ConversionServiceConfig.java
Show resolved
Hide resolved
xtable-service/src/main/java/org/apache/xtable/service/models/ConvertedTable.java
Outdated
Show resolved
Hide resolved
Yes will rebase with the base pr, and address comments |
089942f
to
f920984
Compare
@vinishjail97 Can we go ahead and merge this? |
vinishjail97
approved these changes
May 10, 2025
xtable-service/src/main/java/org/apache/xtable/service/ConversionService.java
Outdated
Show resolved
Hide resolved
This was referenced May 10, 2025
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of the pull request
Brief change log
Verify this pull request