Skip to content

Conversation

rahil-c
Copy link
Contributor

@rahil-c rahil-c commented Apr 24, 2025

What is the purpose of the pull request

Brief change log

  • adds new module for packing rest related dependencies from quarkus
  • adds rest related models
  • adds conversion service logic
  • adds README for running service

Verify this pull request

  • Added new unit tests for service and utils
  • Ran service locally and tested conversions to each table format see screenshots below. Also tried sending multiple conversion requests at similar time to see if they would be handled in parallel.
Screenshot 2025-05-07 at 5 41 24 PM Screenshot 2025-05-07 at 5 38 23 PM

@rahil-c rahil-c force-pushed the rahil-c/rest-service-impl branch from 87e0531 to dada46e Compare May 1, 2025 17:15
@rahil-c rahil-c marked this pull request as ready for review May 8, 2025 00:43
@rahil-c rahil-c changed the title Add module for xtable rest service Add implementation for XTable REST Service May 8, 2025
Copy link
Contributor

@vinishjail97 vinishjail97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you re-base with the base PR and address remaining comments?

@rahil-c
Copy link
Contributor Author

rahil-c commented May 9, 2025

Can you re-base with the base PR and address remaining comments?

Yes will rebase with the base pr, and address comments

@rahil-c rahil-c force-pushed the rahil-c/rest-service-impl branch from 089942f to f920984 Compare May 9, 2025 22:52
@rahil-c
Copy link
Contributor Author

rahil-c commented May 9, 2025

@vinishjail97 Can we go ahead and merge this?

@vinishjail97 vinishjail97 merged commit fc4d6e8 into apache:main May 10, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants