Skip to content

Conversation

@CritasWang
Copy link
Contributor

No description provided.

@CritasWang CritasWang requested a review from Copilot May 9, 2025 02:26
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates the formatting configuration to align with IoTDB’s styling guidelines by updating the Spotless and Google Java Format versions, adjusting profile activation ranges, and applying minor formatting improvements across multiple modules.

  • Update Google Java Format and Spotless versions in the main pom.xml and example modules.
  • Modify JDK profile activation ranges and profile IDs to reflect new JDK support policies.
  • Apply minor cosmetic formatting changes (whitespace adjustments, annotation formatting).

Reviewed Changes

Copilot reviewed 10 out of 10 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
pom.xml Updated formatting versions and modified JDK profile activation ranges/comments.
examples/pulsar/src/main/java/org/apache/iotdb/pulsar/PulsarConsumerThread.java Minor formatting adjustment with an extra newline.
examples/iotdb-spring-boot-start/src/test/java/org/apache/iotdb/iotdbspringbootstartexample/SpringBootIoTDBApplicationTests.java Simplified @Autowired annotation formatting.
examples/iotdb-spring-boot-start/src/main/java/org/apache/iotdb/iotdbspringbootstartexample/service/IoTDBService.java Adjusted field declaration formatting.
examples/iotdb-spring-boot-start/src/main/java/org/apache/iotdb/iotdbspringbootstartexample/IoTDBSpringBootStartApplication.java Removed trailing whitespace.
examples/iotdb-spring-boot-start/pom.xml Added configuration for Spotless Maven plugin.
connectors/hive-connector/src/main/java/org/apache/iotdb/hive/TSFHiveRecordReader.java Inserted additional doc-comments and whitespace formatting.
connectors/hadoop/src/main/java/org/apache/iotdb/hadoop/tsfile/record/HDFSTSRecord.java Applied whitespace and comment formatting adjustments.
connectors/hadoop/src/main/java/org/apache/iotdb/hadoop/tsfile/TSFRecordReader.java Cosmetic reformatting of field declarations.
connectors/hadoop/src/main/java/org/apache/iotdb/hadoop/tsfile/TSFInputFormat.java Added new configuration keys and minor formatting changes.
Comments suppressed due to low confidence (1)

pom.xml:2028

  • [nitpick] Consider verifying that the profile ID '.java-11-below' accurately reflects its purpose, as the change from '.java-11-and-above' may be misleading without further explanation in the documentation.
<id>.java-11-below</id>

@HTHou HTHou merged commit 3e48d26 into apache:master May 9, 2025
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants