Skip to content

Conversation

@xiaoyekanren
Copy link
Contributor

  1. optimized code for sprint-boot-start
  2. fix dependence conflicts for pom

@CritasWang CritasWang requested a review from Copilot June 26, 2025 04:05
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR aims to optimize the spring boot starter code and resolve dependency conflicts. Key changes include:

  • Updating method calls to use boolean property methods (e.g., isEnable_auto_fetch()).
  • Refactoring the IoTDB session properties for better type consistency.
  • Adjustments in multiple POM files to update dependency versions and change parent POMs.

Reviewed Changes

Copilot reviewed 23 out of 24 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
iotdb-spring-boot-starter/src/main/java/org/apache/iotdb/session/IoTDBSessionPool.java Updated method calls to use boolean getters and fixed timeout property references.
iotdb-spring-boot-starter/src/main/java/org/apache/iotdb/config/IoTDBSessionProperties.java Refactored property method signatures and fixed a naming issue for the session timeout property.
iotdb-spring-boot-starter/pom.xml Updated spring.version and added the iotdb-version property.
examples/pom.xml Removed unused modules from the examples and updated references.
examples/mybatisplus-generator/src/test/java/org/apache/iotdb/ApplicationTest.java Commented out the contextLoads test, reducing test coverage.
examples/mybatisplus-generator/pom.xml Updated dependency versions and parent POM, though a typo in the version string was introduced.
Others Minor formatting and XML declaration adjustments in mapper and controller files.
Comments suppressed due to low confidence (1)

examples/mybatisplus-generator/src/test/java/org/apache/iotdb/ApplicationTest.java:34

  • The contextLoads test is commented out, which may reduce test coverage; please re-enable it or ensure that another test covers the same functionality.
//  @Test

@CritasWang CritasWang merged commit 54ca77d into apache:master Jun 26, 2025
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants