Skip to content

RepositoryServiceImpl improvements #54

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 8 commits into
base: trunk
Choose a base branch
from
Open

RepositoryServiceImpl improvements #54

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
4c30360
Replace use of StringBuffer with StringBuilder
dtrebbien Oct 12, 2017
5c20d7f
Fix potential null dereference
dtrebbien Oct 12, 2017
cb21957
Replace size() == 0 with isEmpty()
dtrebbien Oct 12, 2017
9e46ea2
Replace manual addition of array to Collection with addAll(Arrays.asL…
dtrebbien Oct 12, 2017
aed60b4
Replace use of StringBuffer with StringBuilder
dtrebbien Oct 12, 2017
fc6bd79
Delete an extra semicolon that causes "empty statement" warning in Ne…
dtrebbien Oct 12, 2017
b6aad26
Add a return type type parameter to the private Callable interface
dtrebbien Oct 12, 2017
f5ce178
Replace size() != 0 with !isEmpty()
dtrebbien Oct 13, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 9 additions & 5 deletions jackrabbit-spi2dav/src/main/java/org/apache/jackrabbit/spi2dav/RepositoryServiceImpl.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -477,7 +477,7 @@ private String saveGetIdString(ItemId id, SessionInfo sessionInfo) {
}

private String saveGetIdString(ItemId id, NamePathResolver resolver) {
StringBuffer bf = new StringBuffer();
StringBuilder bf = new StringBuilder();
String uid = id.getUniqueID();
if (uid != null) {
bf.append(uid);
Expand Down Expand Up @@ -1388,7 +1388,7 @@ public PropertyInfo getPropertyInfo(SessionInfo sessionInfo, PropertyId property
v = getQValueFactory().create(entity.getContent());
} else {
Reader reader = new InputStreamReader(entity.getContent(), ct.getCharset());
StringBuffer sb = new StringBuffer();
StringBuilder sb = new StringBuilder();
int c;
while ((c = reader.read()) > -1) {
sb.append((char) c);
Expand Down Expand Up @@ -2054,7 +2054,9 @@ public void addVersionLabel(SessionInfo sessionInfo, NodeId versionHistoryId, No
} catch (DavException ex) {
throw ExceptionConverter.generate(ex);
} finally {
request.releaseConnection();
if (request != null) {
request.releaseConnection();
}
}
}

Expand All @@ -2073,7 +2075,9 @@ public void removeVersionLabel(SessionInfo sessionInfo, NodeId versionHistoryId,
} catch (DavException ex) {
throw ExceptionConverter.generate(ex);
} finally {
request.releaseConnection();
if (request != null) {
request.releaseConnection();
}
}
}

Expand Down Expand Up @@ -2183,7 +2187,7 @@ public EventFilter createEventFilter(SessionInfo sessionInfo,
if (nodeTypeNames != null) {
resolvedTypeNames = new HashSet<Name>();
// make sure node type definitions are available
if (nodeTypeDefinitions.size() == 0) {
if (nodeTypeDefinitions.isEmpty()) {
getQNodeTypeDefinitions(sessionInfo);
}
synchronized (nodeTypeDefinitions) {
Expand Down
Loading