Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FIX] make updateACL thread-safe in InMemoryMailboxMapper #2644

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

[FIX] make updateACL thread-safe in InMemoryMailboxMapper #2644

wants to merge 1 commit into from
+93 −67

Conversation

vttranlina
Copy link
Contributor

Using ConcurrentHashMap.compute api of ensuring thread-safe, instead of get then set

@vttranlina vttranlina mentioned this pull request Feb 19, 2025
Closed
@vttranlina
Copy link
Contributor Author

We have another issue with Postgres: RLSSupportPostgresMailboxMapperACLTest does not ensure that updateACL is parallel.

  • PostgresMailboxMapperACLTest pass
  • RLSSupportPostgresMailboxMapperACLTest fail (with logic mailbox_member table)

The RLS will resolve in another pr

@vttranlina vttranlina mentioned this pull request Feb 19, 2025
Open
chibenwa
chibenwa approved these changes Feb 19, 2025
View reviewed changes
Copy link
Contributor

@chibenwa chibenwa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

<3

@vttranlina vttranlina mentioned this pull request Feb 20, 2025
Open
@vttranlina
Copy link
Contributor Author

Ci fail

org.apache.james.mailbox.postgres.mail.PostgresMessageMapperRowLevelSecurityTest.messagesCanBeAccessedAtTheDataLevelByMembersOfTheSameDomain

weird
The commit was not changed anything to Postgres "prod" logic, and PostgresMessageMapperRowLevelSecurityTest

@vttranlina
Copy link
Contributor Author

rebase & squash

@Arsnael
Copy link
Contributor

Arsnael commented Feb 21, 2025

Ci fail

it's flaky, cf linagora#5401

@vttranlina vttranlina mentioned this pull request Feb 24, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chibenwa chibenwa chibenwa approved these changes

@Arsnael Arsnael Arsnael approved these changes

@hungphan227 hungphan227 hungphan227 approved these changes

@quantranhong1999 quantranhong1999 quantranhong1999 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@vttranlina @Arsnael @chibenwa @hungphan227 @quantranhong1999