Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JAMES-2182 Implement: Rename mailbox with rights #2646

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

vttranlina
Copy link
Contributor

@vttranlina vttranlina commented Feb 20, 2025

  • more unit test
  • imap mpt/integration test
  • jmap test

@vttranlina vttranlina force-pushed the renameMailboxWithRights branch from 04626eb to 1cfbe8b Compare February 24, 2025 02:03
@vttranlina vttranlina changed the title WIP - JAMES-2182 Implement: Rename mailbox with rights JAMES-2182 Implement: Rename mailbox with rights Feb 24, 2025
@vttranlina vttranlina marked this pull request as ready for review February 24, 2025 02:03
@@ -111,7 +111,7 @@ class MailboxFactory @Inject() (mailboxManager: MailboxManager,
maySetSeen = MaySetSeen(rights.contains(Right.Seen)),
maySetKeywords = MaySetKeywords(rights.contains(Right.Write)),
mayCreateChild = MayCreateChild(false),
mayRename = MayRename(false),
mayRename = MayRename(rights.contains(Right.DeleteMailbox)),
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://jmap.io/spec-mail.html
Note:

mayRename: Boolean The user may rename the Mailbox or make it a child of another Mailbox. Corresponds to IMAP ACL x (although this covers both rename and delete permissions).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants