KAFKA-7516: Attempt to dynamically load ManagementFactory class #17969
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fail gracefully if not found. This can be the case on Android.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fail gracefully if not found. This can be the case on Android.
With this change, it's no longer necessary for me to stub out JMX classes on Android. I do still need to supply a custom
metric.reportersconfiguration to override the default oforg.apache.kafka.common.metrics.JmxReporter, but that's just configuration.Unfortunately, I don't know of a way to test a static initialization block in a unit test.
Committer Checklist (excluded from commit message)