KAFKA-18209 Cleanup __transaction_state config logic

[wernerdv]

Since the EnforcedCompression and EnforcedRequiredAcks fields are used only in the TransactionStateManager class, I moved them to a companion object.

Committer Checklist (excluded from commit message)

• Verify design and implementation
• Verify test coverage and CI build status
• Verify documentation (including upgrade notes)

[github-actions]

A label of 'needs-attention' was automatically added to this PR in order to raise the
attention of the committers. Once this issue has been triaged, the triage label
should be removed to prevent this automation from happening again.

[wernerdv]

@mimaison Can you tell me if there's anything I can do to improve my PR?

[github-actions]

A label of 'needs-attention' was automatically added to this PR in order to raise the
attention of the committers. Once this issue has been triaged, the triage label
should be removed to prevent this automation from happening again.

[mimaison]

Thanks for the PR. I left a suggestion.

[mimaison]

We also want to use these fields in transactionTopicConfigs()

[wernerdv]

I corrected it.
Is that what you wanted?

[mimaison]

I'm not sure this is the best place to store these values. Have you considered TransactionCoordinator? I'm not saying it should go there, just asking.

[wernerdv]

Since TransactionStateManager#transactionTopicConfigs is used only in TransactionCoordinator, it makes sense to store these values in TransactionCoordinator.

[mimaison]

When I opened the ticket I was hoping we could do a bit more cleanup, but maybe there isn't much to do. The point of the Jira was to investigate and see what could be done.

I left a couple of comments on the changes you propose.

[mimaison]

I'm not sure this is the best place to store these values. Have you considered TransactionCoordinator? I'm not saying it should go there, just asking.